KAFKA-10849: Remove useless ApiKeys#parseResponse and ApiKeys#parseRequest#9741
KAFKA-10849: Remove useless ApiKeys#parseResponse and ApiKeys#parseRequest#9741dengziming wants to merge 1 commit intoapache:trunkfrom
Conversation
|
Hi, @chia7712 , PTAL. |
chia7712
left a comment
There was a problem hiding this comment.
@dengziming Thanks for your patch. Could you also remove ApiKeys#parseResponse and ApiKeys#parseRequest? They are not used anymore.
|
@chia7712 Thank you, I also created an issue and changed the title. |
|
@dengziming Thanks for your updating. |
|
@chia7712 I removed |
There was a problem hiding this comment.
@dengziming Do we maintain this fallback mechanism somewhere?
There was a problem hiding this comment.
@dajac Nice question. It is related to #7409 and the replacement is https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java#L80
1cffbc4 to
bfdac17
Compare
|
@dengziming I just notice there is a PR (#9748) covering this one. Could you please close this PR and then be a reviewer for that PR? |
|
@chia7712 Oh, sorry for the repeated work, I just closed this pr. |
More detailed description of your change
#7409 has removed the conversion to Struct when parsing resp,
ApiVersionsResponse.parsewill be used instead ofAPI_VERSIONS.parseResponse, so the overwrite inApiKeys.API_VERSIONSis useless.Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)