MINOR: Remove assertDoesNotThrow at last line#9854
Merged
chia7712 merged 2 commits intoapache:trunkfrom Jan 13, 2021
Merged
Conversation
chia7712
approved these changes
Jan 11, 2021
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@g1geordie Thanks for your quick fix. LGTM
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Jan 13, 2021
* apache-github/trunk: Only schedule AlterIsr thread when we have an ISR change (apache#9749) MINOR: Fix flaky test shouldQuerySpecificActivePartitionStores (apache#9873) MINOR: Add restoration time tracking (apache#9830) MINOR: Remove unnecessary assertDoesNotThrow (apache#9854)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertDoesNotThrow(.....)in the last lineAbove is unnecessary noise in my commit .
Please let me revert it .
Discuss from
https://github.com/apache/kafka/pull/9785/files#r554586805