Skip to content

KAFKA-12203 Migrate connect:mirror-client module to JUnit 5#9889

Merged
chia7712 merged 5 commits intoapache:trunkfrom
chia7712:KAFKA-12203
Jan 15, 2021
Merged

KAFKA-12203 Migrate connect:mirror-client module to JUnit 5#9889
chia7712 merged 5 commits intoapache:trunkfrom
chia7712:KAFKA-12203

Conversation

@chia7712
Copy link
Copy Markdown
Member

issue: https://issues.apache.org/jira/browse/KAFKA-12203

Only changes the imports and the dependencies.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712 chia7712 requested a review from ijuma January 14, 2021 09:43
Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jan 14, 2021

@chia7712 Given the test results for the last build, I think you can merge this, right?

@chia7712
Copy link
Copy Markdown
Member Author

Given the test results for the last build, I think you can merge this, right?

It produces some failed tests but they pass on my local. I want to check QA again :)

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jan 14, 2021

The failed Streams tests seem unrelated, but they seem to be failing very often.

@chia7712
Copy link
Copy Markdown
Member Author

org.apache.kafka.streams.integration.AdjustStreamThreadCountTest.shouldAddAndRemoveStreamThreadsWhileKeepingNamesCorrect

It is traced by #9888 and #9887

@chia7712 chia7712 merged commit 0c92b83 into apache:trunk Jan 15, 2021
@chia7712 chia7712 deleted the KAFKA-12203 branch March 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants