KAFKA-12230: do not interrupt execution on failure to setPosixFilePermissions on Windows machines#9946
Closed
inponomarev wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-12230: do not interrupt execution on failure to setPosixFilePermissions on Windows machines#9946inponomarev wants to merge 1 commit intoapache:trunkfrom
setPosixFilePermissions on Windows machines#9946inponomarev wants to merge 1 commit intoapache:trunkfrom
Conversation
Member
|
@inponomarev Thanks for the PR. Seems there is already #9947 for this issue that seems to be more sophisticated than just swallowing the exception. I think we should close this PR in favor of #9947? |
Contributor
Author
|
Duplicate of #9947 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StateDirectoryconstructor should catch not onlyIOException, but alsoUnsupportedOperationExceptionin order to work correctly on Windows machines (see KAFKA-12230)
Committer Checklist (excluded from commit message)