MINOR: remove useless repeated method call in KafkaApiTest#9988
Merged
chia7712 merged 1 commit intoapache:trunkfrom Feb 3, 2021
Merged
MINOR: remove useless repeated method call in KafkaApiTest#9988chia7712 merged 1 commit intoapache:trunkfrom
chia7712 merged 1 commit intoapache:trunkfrom
Conversation
Member
Author
|
@ijuma Hello, this is your code, PTAL. |
chia7712
reviewed
Feb 2, 2021
Member
chia7712
left a comment
There was a problem hiding this comment.
@dengziming nice find and thanks for your patch.
There are 94 test cases but no one does use ISR info?
ijuma
approved these changes
Feb 2, 2021
Member
ijuma
left a comment
There was a problem hiding this comment.
LGTM. It may make sense to assert this in some test too.
Member
Author
chia7712
approved these changes
Feb 3, 2021
Member
Could you share the link to me? thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
SetReplicas was invoked twice with same params, I think the author means setIsrs
Summary of testing strategy (including rationale)
QA
Committer Checklist (excluded from commit message)