This repository was archived by the owner on Nov 11, 2025. It is now read-only.
Introduce a BaseScanner class #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us refactor and standarize all scanners. Additionally this class create a good place to have common method which are deuplicated in many places.
Member
Author
|
@kaxil @Humbedooh by refactoring scanners to be classes we will gain multiple things. Apart from encapsulation and introducing more DRYness it will be much more easier to move around code base due to possible types hints. |
kaxil
approved these changes
Dec 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us refactor and standarize all scanners.
Additionally this class create a good place to have common
method which are deuplicated in many places.