Skip to content
This repository was archived by the owner on Nov 11, 2025. It is now read-only.

Conversation

@turbaszek
Copy link
Member

@turbaszek turbaszek commented Oct 24, 2020

This commit refactors the code base to create an installable
kibble application. In this way we will be able to do:

pip install .
# or once released:
pip install apache-kibble

and then

➜ kibble --help
Help hello to kibble!

Related to: #64
Closes: #37

What has happened in this PR:

  • move api/ and setup/ under kibble/ directory
  • adjust all imports and files paths
  • create kibble/settings.py to store common constants
  • create kibble/version.py with version information
  • create setup.py with requirements and remove requirements.txt file
  • create kibble/__main__.py as a starting point for kibble application - that's what will be invoked when users do kibble --help
  • adjust docker file and docker-compose to make everything works

This commit refactors the code base to create an installable
kibble application.
Co-authored-by: Michał Słowikowski <michalslowikowski00@gmail.com>
Copy link
Contributor

@michalslowikowski00 michalslowikowski00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

@turbaszek turbaszek merged commit edb9a91 into apache:master Oct 24, 2020
@turbaszek turbaszek deleted the make-kibble-package branch October 24, 2020 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider moving /setup content to main directory

2 participants