This repository was archived by the owner on Nov 11, 2025. It is now read-only.
Use KibbleConfigParser in setup script #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
commented
Oct 27, 2020
| try: | ||
| return bool(self.get(section, key)) | ||
| except Exception: | ||
| raise TypeError("Unable to convert value to bool") |
Member
Author
There was a problem hiding this comment.
@skekre98 unfortunately I had to remove those method as it seems that ConfigParser already implements getint and getboolean
Contributor
There was a problem hiding this comment.
No problem, I'm sure they have a better implementation anyways 😄
Member
Author
There was a problem hiding this comment.
@skekre98 would you mind reviewing those changes? 😉
skekre98
approved these changes
Oct 27, 2020
Closed
Merged
turbaszek
referenced
this pull request
Dec 12, 2020
Before this commit I got this error when running Kibble locally: This was because https://github.com/apache/kibble/pull/83 replaced kibble.yaml with kibble.ini This PR reads the config from `kibble.ini`. This also adds a network to docker-compose file without which I was getting host not found error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up after #74
We still need to remove the using of
kibble.yamlin few places but I wanted to limit a scope of this changes (for example it would be good to refactor connecting to es database - currently we implement same class two times #84 ).