Skip to content

Conversation

@hanicz
Copy link
Contributor

@hanicz hanicz commented Dec 8, 2025

KNOX-3228 - KnoxCLI integration test

What changes were proposed in this pull request?

  • Adds a new integration tests for KnoxCLI alias related commands.
  • Adds the necessary steps and libraries to call KnoxCLI commands in integration tests.

How was this patch tested?

Ran the integration tests locally
docker compose -f ./.github/workflows/compose/docker-compose.yml up --exit-code-from tests tests

@moresandeep
Copy link
Contributor

Looks like the PR was opened before i merged my changes that replace host name from knox to localhost

tests-1 | host = 'knox', port = 8443, family = <AddressFamily.AF_UNSPEC: 0> 


tests-1 | type = <SocketKind.SOCK_STREAM: 1>, proto = 0, flags = 0

Notice the host name is knox it was fixed to localhost but the way this workflow runs the changes have to be in master.
You can add skip-tests label to skip the test and commit. This should not be a problem going forward.

@hanicz hanicz closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants