Skip to content

Fix should listen on 0.0.0.0 in docker image#1784

Merged
PragmaTwice merged 1 commit intoapache:unstablefrom
git-hulk:fix/docker-bind-address
Sep 26, 2023
Merged

Fix should listen on 0.0.0.0 in docker image#1784
PragmaTwice merged 1 commit intoapache:unstablefrom
git-hulk:fix/docker-bind-address

Conversation

@git-hulk
Copy link
Copy Markdown
Member

This fixes #1783

@git-hulk git-hulk marked this pull request as ready for review September 26, 2023 10:45
@PragmaTwice PragmaTwice merged commit 7f0c515 into apache:unstable Sep 26, 2023
@tisonkun
Copy link
Copy Markdown
Member

We'd better to add some sanity checks in:

check-docker:
name: Check Docker image
needs: [precondition, check-and-lint, check-typos]
if: ${{ needs.precondition.outputs.docs_only != 'true' }}
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- name: Get core numbers
run: echo "NPROC=$(nproc)" >> $GITHUB_ENV
- uses: docker/build-push-action@v3
with:
context: .
build-args: MORE_BUILD_ARGS=-j${{ env.NPROC }}
push: false
tags: kvrocks:ci
outputs: type=docker
- name: Test built image
run: docker run --rm kvrocks:ci -v

@git-hulk
Copy link
Copy Markdown
Member Author

We'd better to add some sanity checks in:

check-docker:
name: Check Docker image
needs: [precondition, check-and-lint, check-typos]
if: ${{ needs.precondition.outputs.docs_only != 'true' }}
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- name: Get core numbers
run: echo "NPROC=$(nproc)" >> $GITHUB_ENV
- uses: docker/build-push-action@v3
with:
context: .
build-args: MORE_BUILD_ARGS=-j${{ env.NPROC }}
push: false
tags: kvrocks:ci
outputs: type=docker
- name: Test built image
run: docker run --rm kvrocks:ci -v

Sure, I will file an issue to track this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenDAL's kvrocks tests failing after 2.6.0 released

5 participants