[KYLIN-4886] Bump the rocksdbjni dependency version to 5.18.4#1557
Closed
liusheng wants to merge 1 commit intoapache:masterfrom
Closed
[KYLIN-4886] Bump the rocksdbjni dependency version to 5.18.4#1557liusheng wants to merge 1 commit intoapache:masterfrom
liusheng wants to merge 1 commit intoapache:masterfrom
Conversation
This change Bump the rocksdbjni dependency version to 5.18.4 to support ARM64 platform.
Pull Request Test Coverage Report for Build 6828
💛 - Coveralls |
10 tasks
Author
|
Hi @hit-lacus @zzcclp Could you please take a look this PR ? Thanks a lot! |
Author
|
Hi, could anyone can help to review this PR ? |
Author
|
Hi @hit-lacus |
Author
|
merged changes of this pr to #1558 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
A special rocksdbjni version for aarch64 has been released by rocksdb community. [1][2]
This patch bumps the rocksdbjni version to 5.18.4 to make the Storm can be built in aarch64.
[1] https://github.com/facebook/rocksdb/releases/tag/v5.18.4
[2] facebook/rocksdb#6250
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.documentbranchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...