-
Notifications
You must be signed in to change notification settings - Fork 982
[KYUUBI #708] [BUILD] Upgrade scala-maven-plugin to 4.5.3 #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
==========================================
- Coverage 80.53% 80.47% -0.07%
==========================================
Files 122 122
Lines 4743 4738 -5
Branches 574 574
==========================================
- Hits 3820 3813 -7
- Misses 601 603 +2
Partials 322 322
Continue to review full report at Codecov.
|
| <maven.plugin.antrun.version>3.0.0</maven.plugin.antrun.version> | ||
| <maven.plugin.build.helper.version>3.2.0</maven.plugin.build.helper.version> | ||
| <maven.plugin.compiler.version>3.8.1</maven.plugin.compiler.version> | ||
| <!-- DO NOT bump 4.4.0, see https://github.com/NetEase/kyuubi/pull/441 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a verification that #441 still exists in 4.5.3, I think we need to figure out what happens in scala maven plugin before upgrading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I will upgrade the version of scala-maven-plugin to 4.5.3 and pass the local verification, and run the build/dist --tgz command to package normally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it also passed ci but not the case reported by #441
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a new comment here and skip this version too.
<!-- DO NOT bump 4.4.0, see https://github.com/NetEase/kyuubi/pull/441 -->
<!-- DO NOT bump 4.5.3, see https://github.com/NetEase/kyuubi/issues/708 -->
pom.xml
Outdated
| <!-- DO NOT bump 4.4.0, see https://github.com/NetEase/kyuubi/pull/441 --> | ||
| <maven.plugin.scala.version>4.3.0</maven.plugin.scala.version> | ||
| <!-- DO NOT bump 4.5.3, see https://github.com/NetEase/kyuubi/issues/708 --> | ||
| <maven.plugin.scala.version>4.5.3</maven.plugin.scala.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert it to 4.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaooqinn I has now been revert and add a new comment here and skip this version too.
pan3793
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks, merged for v1.3.0. |
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request