Remove CLI tools from log4j-core and log4j-1.2-api#2435
Merged
Conversation
ppkarwasz
force-pushed
the
feature/remove-picocli
branch
from
4d62b6d to
0d582e6
Compare
Contributor
Author
|
The build failure is an April's Fool I played on myself: the failing test was disabled until |
ppkarwasz
force-pushed
the
feature/remove-picocli
branch
2 times, most recently
from
0e596ed to
bdd29ca
Compare
We remove the command line tools to generate logger wrappers and convert Log4j 1.x configuration. The tools have been submitted to Log4j Transform: * apache/logging-log4j-transform#92 * apache/logging-log4j-transform#93 and are not necessary at runtime. The `Log4j1ConfigurationFactory` that has been removed from `log4j-1.2-api` is an **older** and deprecated version of the `PropertiesConfigurationFactory`.
ppkarwasz
force-pushed
the
feature/remove-picocli
branch
from
bdd29ca to
6a1e0f0
Compare
vy
approved these changes
Apr 8, 2024
Member
vy
left a comment
vy
left a comment
There was a problem hiding this comment.
You remove Java files and that does not cause any changes in the source code. Hilarious! A solid indicator of a-feature-that-could-have-been-a-separate-project. Good job @ppkarwasz!
Could you double-check that the src/site doesn't need to be updated, please?
The documentation for the code generators are replaced with a link to the Apache Log4j Transform project documentation.
Contributor
Author
|
@vy,
I migrated the documentation of the code generator to the apache/logging-log4j-transform#92 PR. As far as I could see, the Log4j 1.x configuration converter was never documented on our site. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We remove the command line tools to generate logger wrappers and convert Log4j 1.x configuration.
The tools have been submitted to Log4j Transform:
log4j-corelogging-log4j-transform#92log4j-1.2-apilogging-log4j-transform#93and are not necessary at runtime.
The
Log4j1ConfigurationFactorythat has been removed fromlog4j-1.2-apiis an older and deprecated version of thePropertiesConfigurationFactory.