Conversation
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
# Conflicts: # src/site/antora/modules/ROOT/pages/manual/customloglevels.adoc
# Conflicts: # src/site/antora/modules/ROOT/examples/manual/customloglevels/log4j2.json # src/site/antora/modules/ROOT/pages/manual/customloglevels.adoc
Editing a Ditaa source requires significant Ascii art skills, which makes it difficult to modify. This contradicts with our initial motivation to move away from images. Switching to PlantUML instead, which is a no-brainer to use and adapt.
We update the `Web Applications` page by: * merging the `webapp.html`, `log4j-web.html`, `log4j-jakarta-web.xml` and `log4j-taglib.html` pages, * providing a table with all the initialization parameters, * moving the description of the web lookup and servlet appender to the right pages.
vy
requested changes
Jul 1, 2024
Member
vy
left a comment
vy
left a comment
There was a problem hiding this comment.
I can't imagine the effort you put into verifying all these in several application servers! 🤯 Great job @ppkarwasz! 🙇
The browser does not send the fragment part to the server, when requesting a page. So all redirects from `a.html#fragment` to `b.html` will not work. On the other hand you can redirect `a.html` to `b.html#fragment`, but you need to add the NE (disables escaping) flag.
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
vy
approved these changes
Jul 2, 2024
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We update the
Web Applicationspage by:webapp.html,log4j-web.html,log4j-jakarta-web.xmlandlog4j-taglib.htmlpages,Part of #2541, closes #2547.