Migrate log4j-jdbc-dbcp2 to JUnit 5

[ninetteadhikari]

Hello! 👋

We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5. This PR migrates the tests located in log4j-jdbc-dbcp2 to JUnit5.

• Our idea is to deliver small size PRs with the changes. If you'd like us to do it in some other way, please tell us so
• Part of the deliverable is to transport these changes from the 2.x branch to the main branch. Should we create the PR against main once this PR is merged?

Thank you!

Checklist

• Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
• ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
• Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
• Tests for the changes are provided
• Commits are signed (optional, but highly recommended)

[github-actions]

Job	Requested goals	Build Tool Version	Build Outcome	Build Scan®
build-macos-latest	clean install	3.9.8	❌
build-ubuntu-latest	clean install	3.9.8	❌
build-windows-latest	clean install	3.9.8	❌

Generated by gradle/develocity-actions

[ninetteadhikari]

hi @grobmeier we started working on migrating modules from JUnit 4 to 5. As we continue working on other modules we wanted to get your feedback. Let us know if we are going in the right direction. Thanks!:)

[vy]

Hey @ninetteadhikari! Thanks so much for the contribution! 😍

You're going in the right direction. Some guidelines you might benefit from:

• Submit PRs per module
• Make sure you read the development guide
• Make sure ./mvnw verify -pl :<module-name> passes before submitting the PR
• Make sure you follow our coding conventions (final modifiers for variables, etc.)
• Make sure the visibility of test classes are sufficiently decreased as you migrate to JUnit 5 (i.e., classes and methods can be package-local instead of public)
• If you need to rewrite assertions, prefer AssertJ [fluent API] over JUnit

[I will review the PR right away...]

[ninetteadhikari]

Do you want this PR to be made to the main branch as well?

That will be awesome! 🤩

[vy]

Do you want this PR to be made to the main branch as well?

@ninetteadhikari, this is not needed anymore. I've ported it myself. 💪