Remove ancient test fixtures and dependencies#3039
Merged
Conversation
The `@TempLoggingDir` JUnit 5 extensions create a totally deterministic directory to hold the log files for tests. Since the directory is deleted only if all the tests succeed, this causes a problem with test reruns.
This removes the test dependency on `oro:oro` and the `VelocityTest`, which uses Apache Velocity 1.7 for no clear reason.
vy
approved these changes
Oct 7, 2024
Since `log4j-1.2-api` is a legacy component, reactivating disabled tests is not worth the effort. Therefore, we remove all the disabled tests and the test fixtures they used.
Contributor
Author
|
@vy, I also removed the disabled tests in Personally I find that enabling new tests in |
…x/remove-dinosaurs
vy
approved these changes
Oct 7, 2024
Member
vy
left a comment
vy
left a comment
There was a problem hiding this comment.
I also removed the disabled tests in
DOMTestCaseand all the test fixtures they used.
+1
Personally I find that enabling new tests in
log4j-1.2-apiis not worth the effort, except if users report a bug
+1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the test dependency on
oro:oroand theVelocityTest, which uses Apache Velocity 1.7 for no clear reason.