Correct example property syntax under ScriptPatternSelector#3092
Merged
ppkarwasz merged 1 commit intoapache:2.xfrom Oct 16, 2024
Merged
Correct example property syntax under ScriptPatternSelector#3092ppkarwasz merged 1 commit intoapache:2.xfrom
ppkarwasz merged 1 commit intoapache:2.xfrom
Conversation
Contributor
|
Thanks for your PR, your changes should be already online. |
hulkoba
pushed a commit
to neighbourhoodie/logging-log4j2
that referenced
this pull request
Oct 21, 2024
…elector. (apache#3092) Fixes apache#3078 Co-authored-by: Martin Dorey <martindorey@gmail.com>
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3078
Attempting to do as requested in #3078 (comment) for @ppkarwasz.
Just excuses here, I'm afraid:
I don't know what I'm doing wrt branches, here or otherwise, I'm afraid.
Java 17 would be tricky.
I'm hoping it's regarded as trivial.
Yeah, I didn't do that, but apparently the examples aren't tested, so that's not a regression.
I don't have that set up.