Fix(#2769): Modify the annotation processor in 2.x to give a warning if a plugin builder attribute does not have a public setter.#3195
Conversation
ppkarwasz
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I added some minor remarks below.
If you haven't done it already, please sign the ASF ICLA.
|
Sounds good @ppkarwasz let me fix and rebase this! 🙂 |
50b1e54 to
d6e4898
Compare
d6e4898 to
024654e
Compare
|
I sent you an invitation to the Apache Slack to the address you use in your commits. |
|
Hi @ppkarwasz the build was failing, hence I put the pr in draft 🥲. Thanks for approving it, but I will have to make a revision. I am not sure I got the slack invitation, was the email jaykataria1111@gmail.com? |
|
No, I used the one from you University/Alma Mater that you use for your commits. |
|
Hi @ppkarwasz i am trying to move away from that email, because I don't have access to that anymore 🥲 will change it in my commits as well! I apologize |
ppkarwasz
left a comment
There was a problem hiding this comment.
Hi @jaykataria1111,
The OSGi fail is due to an "unauthorized" usage of Commons Lang 3. All optional Maven dependencies, must be explicitly marked as optional in OSGi, if we need them. In this case we don't.
a4dc84d to
0cc7f96
Compare
…rning if a plugin builder attribute does not have a public setter.
0cc7f96 to
1203725
Compare
|
Hi @ppkarwasz addressed all the comments here we should be good :) |
ppkarwasz
left a comment
There was a problem hiding this comment.
Thank you! I'll merge the PR, when the CI checks succeed.
The following commit modifies the annotation processor in 2.x to shell out a warning if the plugin builder attribute does not have a public setter.
A
@SuppressWarnings("log4j.public.setter")attribute can be used to ignore this compilation warning incase it is a known issue.Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory