Fix(#3239) NPE, for RegexFilter creator.#3265
Merged
ppkarwasz merged 1 commit intoapache:2.xfrom Jan 8, 2025
Merged
Conversation
jvz
approved these changes
Dec 3, 2024
Generated by gradle/develocity-actions |
ppkarwasz
reviewed
Dec 3, 2024
Contributor
ppkarwasz
left a comment
ppkarwasz
left a comment
There was a problem hiding this comment.
Can you add a unit test to see if createFilter does not throw with all parameters (except regex) equal to null?
jaykataria1111
force-pushed
the
pr3239
branch
from
75a5b04 to
39051d2
Compare
Contributor
Author
|
@ppkarwasz added the test, and updated the code :) |
Contributor
Author
|
@ppkarwasz , this one is still open I will rebase this just for tracking purposes, I do not recall any action items on this would you remember? |
Contributor
Author
|
@ppkarwasz I have rebased the commit, let me know if anything else is needed on this or we can close this out. Thanks for this! |
Contributor
|
Can you add a changelog entry? |
Contributor
Author
|
Sure I should be able to do it tonight
Regards,
Jay Katariya
…On Tue, Jan 7, 2025 at 7:36 AM Piotr P. Karwasz ***@***.***> wrote:
Can you add a changelog entry?
—
Reply to this email directly, view it on GitHub
<#3265 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHVIPUX2I7VBWK2W5I66IPD2JPYAHAVCNFSM6AAAAABS4XAMBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZVGU4TOOJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
@ppkarwasz posted an update . |
27 tasks
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #3239
Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory