Improve configuration error handling of HttpAppender#3438
Merged
ppkarwasz merged 9 commits intoapache:2.xfrom Feb 16, 2025
Suvrat1629:2.x
Merged
Improve configuration error handling of HttpAppender#3438ppkarwasz merged 9 commits intoapache:2.xfrom Suvrat1629:2.x
ppkarwasz merged 9 commits intoapache:2.xfrom
Suvrat1629:2.x
Conversation
Generated by gradle/develocity-actions |
Contributor
|
There are formatting errors in your PR. Run: to fix them. |
Contributor
Author
|
@ppkarwasz |
Contributor
We have two style rules for the code:
I'll look at your PR in the weekend. |
Contributor
Author
|
Yeah I just realized that when i ran |
Contributor
Author
|
@ppkarwasz gentle ping! Could you please take a look :) Thank you! |
ppkarwasz
reviewed
Feb 13, 2025
Contributor
|
Fixes #3011 |
27 tasks
Contributor
|
Thank you for your contribution. |
jvz
pushed a commit
that referenced
this pull request
Jul 31, 2025
This PR introduces improvements to `HttpAppender` and adds a new test class, `HttpAppenderBuilderTest`, to enhance test coverage. The changes include: * Updating `HttpAppender` to improve validating behavior. * Adding HttpAppenderBuilderTest.java to verify the builder logic for HttpAppender. Ensuring that missing configurations (e.g., URL, Layout) correctly log errors. Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
jvz
added a commit
that referenced
this pull request
Aug 1, 2025
* Improve configuration error handling of HttpAppender (#3438) This PR introduces improvements to `HttpAppender` and adds a new test class, `HttpAppenderBuilderTest`, to enhance test coverage. The changes include: * Updating `HttpAppender` to improve validating behavior. * Adding HttpAppenderBuilderTest.java to verify the builder logic for HttpAppender. Ensuring that missing configurations (e.g., URL, Layout) correctly log errors. Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org> * Fix compilation errors in HttpAppenderBuilderTest --------- Co-authored-by: Suvrat Acharya <140749446+Suvrat1629@users.noreply.github.com> Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces improvements to HttpAppender and adds a new test class, HttpAppenderBuilderTest, to enhance test coverage. The changes include:
Updating HttpAppender.java to improve logging behavior.
Adding HttpAppenderBuilderTest.java to verify the builder logic for HttpAppender.
Ensuring that missing configurations (e.g., URL, Layout) correctly log errors.
Fixes #3011
Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory