[MCHANGES-411] Issue link is mangled if project.issueManagement.url does not end with slash (/)

[jira-importer]

Unassigned Developer opened MCHANGES-411 and commented

Consider the follwing block in your POM:

<issueManagement>
     <system>GitHub</system>
     <url>https://github.com/michael-o/tomcatspnegoad/issues</url>
</issueManagement>

The changes report will turn the issue link into https://github.com/michael-o/tomcatspnegoad/%ISSUE% because here (

maven-changes-plugin/src/main/java/org/apache/maven/plugins/changes/ChangesReportGenerator.java

Lines 634 to 646 in e85711f

	private String parseIssueLink( String issue, String system )
	{
	String parseLink;
	String issueLink = this.issueLinksPerSystem.get( system );
	parseLink = issueLink.replaceFirst( ISSUE_TOKEN, issue );
	if ( parseLink.contains( URL_TOKEN ) )
	{
	String url = this.url.substring( 0, this.url.lastIndexOf( "/" ) );
	parseLink = parseLink.replaceFirst( URL_TOKEN, url );
	}
	return parseLink;
	}

) it will chop off the last components, ignoring it will end with a slash or not.

---

No further details from MCHANGES-411

[jira-importer]

Elliotte Rusty Harold commented

Do you have a reproducible test case? Looking at the code I don't immediately see how this can happen.

[jira-importer]

Slawomir Jaranowski commented

Michael Osipov can you retest with the latest master version?