Conversation
elharo
changed the title
elharo
changed the title
slawekjaranowski
requested changes
Dec 30, 2024
Member
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
We should use org.hamcrest:hamcrest and exclude hamcrest-core from junit dependencies.
Contributor
Author
Better yet, we can just remove the hamcrest dependency completely. There's only one trivial usage in this plugin. |
slawekjaranowski
approved these changes
Dec 30, 2024
Member
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
Please update PR and jira title to according change does.
elharo
changed the title
elharo
changed the title
Contributor
Author
|
Updated title. This is one of several changes to address MCHANGES-462 |
|
Resolve #357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I finally understand why the dependency analyzer has such a tizzy about hamcrest dependencies. 3.0 and 1.3 seem to have put different classes in different artifacts, and JUnit 4 depends on Hamcrest 1.3. As long as we match the Hamcrest version to the JUnit version everything's hunky dory. However if we let dependabot or anything else upgrade to Hamcrest 3, things go haywire.
See MDEP-715