Escape JIRA reserved words in JqlQueryBuilder

[garydgregory]

Fix blocker for [EXEC-124] maven-changes-plugin:3.0.0-M2 causes "Error in the JQL Query"

I can't create a ticket in the MCHANGES Jira project for some reason, so here is when it is blocking:

https://issues.apache.org/jira/browse/EXEC-124

I'd post this to the {{MCHANGES}} Jira project but I don't seem to have rights for that...

Apache Commons Exec gets a MojoExecutionException: Failed to query issues; response 400

[INFO] Generating "JIRA Report" report   --- maven-changes-plugin:3.0.0-M2:jira-changes
[ERROR] Error in the JQL Query: 'EXEC' is a reserved JQL word. You must surround it in quotation marks to use it in a query. (line 1, character 11)
[WARNING] 
org.apache.maven.plugin.MojoExecutionException: Failed to query issues; response 400
    at org.apache.maven.plugins.changes.jira.RestJiraDownloader.reportErrors (RestJiraDownloader.java:453)
    at org.apache.maven.plugins.changes.jira.RestJiraDownloader.search (RestJiraDownloader.java:402)
    at org.apache.maven.plugins.changes.jira.RestJiraDownloader.doExecute (RestJiraDownloader.java:361)
    at org.apache.maven.plugins.changes.jira.JiraChangesReport.executeReport (JiraChangesReport.java:339)
    at org.apache.maven.reporting.AbstractMavenReport.generate (AbstractMavenReport.java:358)
    at org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument (ReportDocumentRenderer.java:199)
    at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render (DefaultSiteRenderer.java:302)
    at org.apache.maven.plugins.site.render.SiteMojo.renderNonDoxiaDocuments (SiteMojo.java:282)
    at org.apache.maven.plugins.site.render.SiteMojo.renderLocale (SiteMojo.java:147)
    at org.apache.maven.plugins.site.render.SiteMojo.execute (SiteMojo.java:112)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
    at java.lang.reflect.Method.invoke (Method.java:580)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)

Run:

git clone https://github.com/apache/commons-exec.git
cd commons-exec
mvn clean site -DskipTests

[pzygielo]

I can't create a ticket in the MCHANGES Jira project for some reason

Everyone should be able to create issue here.

I'd post this to the {{MCHANGES}} Jira project but I don't seem to have rights for that...

Everyone should be able to create issue here.

[garydgregory]

@pzygielo

Then please fix https://maven.apache.org/plugins/maven-changes-plugin/issue-management.html

[slawekjaranowski]

Then please fix https://maven.apache.org/plugins/maven-changes-plugin/issue-management.html

Was updated in #122, will be visible with next release.

Now is visible at https://maven.apache.org/plugins/

[slawekjaranowski]

@garydgregory what do you think about to change title of PR and commit subject to something like:
Escape JIRA reserved words in JqlQueryBuilder
to show what we exectly did in change

[garydgregory]

@slawekjaranowski
Done!

[garydgregory]

@slawekjaranowski

Thank you for the review and merge.

Would you please set expectations for a release timeframe? This is blocking Commons Exec unless I use a snapshot or local build.

TY!

[slawekjaranowski]

@slawekjaranowski

Thank you for the review and merge.

Would you please set expectations for a release timeframe? This is blocking Commons Exec unless I use a snapshot or local build.

TY!

I have a plan to release today or tomorrow evening.