Skip to content

[MCHANGES-432] Remove deprecated parameter - escapeHtml - cleanups #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slawekjaranowski merged 1 commit into from
Nov 22, 2024
Merged

[MCHANGES-432] Remove deprecated parameter - escapeHtml - cleanups #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/org/apache/maven/plugins/changes/ChangesReport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,6 @@ public void executeReport(Locale locale) throws MavenReportException {
report.setAuthor(changesXml.getAuthor());
report.setTitle(changesXml.getTitle());

report.setEscapeHTML(true);

// Create a case insensitive version of issueLinkTemplatePerSystem
// We need something case insensitive to maintain backward compatibility
if (issueLinkTemplatePerSystem == null) {
Expand Down
19 changes: 1 addition & 18 deletions src/main/java/org/apache/maven/plugins/changes/ChangesReportGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,6 @@ public class ChangesReportGenerator extends AbstractIssuesReportGenerator {

private boolean linkToFeed;

/**
* @since 2.4
*/
private boolean escapeHTML;

/**
* @since 2.4
*/
Expand All @@ -94,14 +89,6 @@ public ChangesReportGenerator(List<Release> releaseList) {
this.releaseList = releaseList;
}

public boolean isEscapeHTML() {
return escapeHTML;
}

public void setEscapeHTML(boolean escapeHTML) {
this.escapeHTML = escapeHTML;
}

public String getSystem() {
return system;
}
Expand Down Expand Up @@ -211,11 +198,7 @@ private void constructAction(Sink sink, ResourceBundle bundle, Action action) {

String actionDescription = action.getAction();

if (escapeHTML) {
sink.text(actionDescription);
} else {
sink.rawText(actionDescription);
}
sink.text(actionDescription);

// no null check needed classes from modello return a new ArrayList
if (StringUtils.isNotEmpty(action.getIssue())
Expand Down