[MDEP-439] maven-dependency-plugin not compatible with Java 8

[jira-importer]

Steven Schlansker opened MDEP-439 and commented

maven-dependency-plugin uses asm 3.x, which is not compatible with Java 8 (throws ArrayIndexOutOfBoundsException)

This seriously hinders the use of Maven with Java 8, which is now the "production" version of Java.

---

Affects: 2.8

Issue Links:

• MNG-5551 check that everything compile and run fine with Java 8

• MSHARED-327 maven-dependency-analyzer not compatible with Java 8
  ("depends upon")

Remote Links:

• GitHub Pull Request #56
  

0 votes, 5 watchers

[jira-importer]

Mirko Friedenhagen commented

The analyze goal depends on the org.apache.maven.shared:maven-dependency-analyzer:1.4 which depends on
asm 3.3.1. The trunk already moved to 4.2. I now just switched the version to org.ow2.asm:asm:5.0.1, local tests run successfully in the shared component. However there are currently no tests for Java8 constructs. I updated the shared component as first step. http://svn.apache.org/viewvc?view=revision&revision=1582244

[jira-importer]

Mirko Friedenhagen commented

Stephen, do you have a testcase for this? Currently I am not able to reproduce this easily, I created a sample library with a Lambda expression and included this one in another library as dependency, dependency:analyze runs just fine.

[jira-importer]

Steven Schlansker commented

https://github.com/stevenschlansker/mdep-439-analyze-java8

[jira-importer]

Mirko Friedenhagen commented

Hello Steven,

my local manual tests ran successfully with a SNAPSHOT of org.apache.maven.shared:maven-dependency-analyzer

[jira-importer]

Steven Schlansker commented

Confirmed working for me, thanks so much! Hopefully we can get a release of maven-dependency-plugin so everyone can benefit by default :)

[jira-importer]

Steven Schlansker commented

Heads up, you also need a patch like this, otherwise you get exceptions like:

Caused by: java.lang.IllegalArgumentException: INVOKESPECIAL/STATIC on interfaces require ASM 5
at org.objectweb.asm.MethodVisitor.visitMethodInsn(Unknown Source)
at org.objectweb.asm.ClassReader.a(Unknown Source)
at org.objectweb.asm.ClassReader.b(Unknown Source)
at org.objectweb.asm.ClassReader.accept(Unknown Source)
at org.objectweb.asm.ClassReader.accept(Unknown Source)
at org.apache.maven.shared.dependency.analyzer.asm.DependencyClassFileVisitor.visitClass(DependencyClassFileVisitor.java:70)
at org.apache.maven.shared.dependency.analyzer.ClassFileVisitorUtils.visitClass(ClassFileVisitorUtils.java:154)

Index: src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultAnnotationVisitor.java

---

--- src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultAnnotationVisitor.java (revision 1586727)
+++ src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultAnnotationVisitor.java (working copy)
@@ -36,7 +36,7 @@

public DefaultAnnotationVisitor(ResultCollector resultCollector)
{

  super(Opcodes.ASM4);

  super(Opcodes.ASM5);
  this.resultCollector = resultCollector;

}

Index: src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultClassVisitor.java

---

--- src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultClassVisitor.java (revision 1586727)
+++ src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultClassVisitor.java (working copy)
@@ -49,7 +49,7 @@

public DefaultClassVisitor(SignatureVisitor signatureVisitor, AnnotationVisitor annotationVisitor, FieldVisitor fieldVisitor, MethodVisitor methodVisitor, ResultCollector resultCollector)
{

  super(Opcodes.ASM4);

  super(Opcodes.ASM5);
  this.signatureVisitor = signatureVisitor;
  this.annotationVisitor = annotationVisitor;
  this.fieldVisitor = fieldVisitor;

Index: src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultFieldVisitor.java

---

--- src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultFieldVisitor.java (revision 1586727)
+++ src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultFieldVisitor.java (working copy)
@@ -37,7 +37,7 @@

public DefaultFieldVisitor(AnnotationVisitor annotationVisitor, ResultCollector resultCollector)
{

  super(Opcodes.ASM4);

  super(Opcodes.ASM5);
  this.annotationVisitor = annotationVisitor;
  this.resultCollector = resultCollector;

}
Index: src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java

---

--- src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java (revision 1586727)
+++ src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java (working copy)
@@ -39,7 +39,7 @@

public DefaultMethodVisitor(AnnotationVisitor annotationVisitor, SignatureVisitor signatureVisitor, ResultCollector resultCollector)
{

  super(Opcodes.ASM4);

  super(Opcodes.ASM5);
  this.annotationVisitor = annotationVisitor;
  this.signatureVisitor = signatureVisitor;
  this.resultCollector = resultCollector;

Index: src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultSignatureVisitor.java

---

--- src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultSignatureVisitor.java (revision 1586727)
+++ src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultSignatureVisitor.java (working copy)
@@ -38,7 +38,7 @@

public DefaultSignatureVisitor(ResultCollector resultCollector)
{

  super(Opcodes.ASM4);

  super(Opcodes.ASM5);
  this.resultCollector = resultCollector;

}

[jira-importer]

Olivier Lamy commented

If I use your sample project, I got :
[WARNING] Unused declared dependencies found:
[WARNING] org.slf4j:slf4j-api:jar:1.7.6:compile

Which is wrong as slf4j-api is used.

Maybe I miss something but for me it doesn't work.

[jira-importer]

Mirko Friedenhagen commented

Olivier Lamy, you are right, with maven-dependency-plugin version 2.8, I get an additional error:

Unable to process: org.sugis.maven.Java8Slf4jDep

Using maven-dependency-plugin:2.9-SNAPSHOT (replaced maven-dependency-analyzer's version with 1.5-SNAPSHOT) I get your error message although slf4j-api is in use.

[jira-importer]

Mirko Friedenhagen commented

I now "rewrote" Steven's example:

1. first attempt: only JDK7 is a prerequisite (only logged sth. and set source and target in the POM to 1.7) and even then get the undeclared dependency error, strange.
2. Extracted the defined Logger and returned it from wat:

default Logger wat()
{
    Supplier<Instant> time = Clock.systemUTC()::instant;
    final Logger logger = LoggerFactory.getLogger(Java8Slf4jDep.class);
    logger.info(time.get().toString());
    return logger;
}

Now the error is gone. Are only the method signatures inspected?

[jira-importer]

Olivier Lamy commented

No the DefaultMethodVisitor class need to be updated.
I will

[jira-importer]

Olivier Lamy commented

fixed with http://svn.apache.org/r1590555

[jira-importer]

Olivier Lamy commented

fixed.
Thanks for the test project.

[jira-importer]

Vladimir Dergachev commented

Sorry, ignore my message, i created a new issue here https://issues.apache.org/jira/browse/MDEP-560