[MEAR-153] Skinny Modules -- not just WARs

[jira-importer]

Roland Asmann opened MEAR-153 and commented

Currently it is only possible to have the plugin filter WARs to make them 'skinny', however this could be very useful for other modules as well!

In my project I have both a WAR and a SAR that should share several libraries. As standalone artifacts, they should both package it themselves, but in the deployed EAR I get classloading-errors when they don't have the libs shared in the EAR.

I traced a solution to the method 'EarModule.getLibDir()', which is only implemented with a value in the 'WebModule'-subclass.
Since I am not familiar with all the module-types, I attached a solution that ONLY handles the SarModule, but this can probably used in all other Modules that contain libs as well.

---

Affects: 2.7

Attachments:

• AbstractEarModule.java.patch (639 bytes)
• SarModule.java.patch (502 bytes)

Issue Links:

• MEAR-267 assembly.xml contains incorrect references to modules
  ("fixes")
• MRAR-9 Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive

Remote Links:

• GitHub Pull Request #24
  
• "Maven EAR Plugin 3.2.0 with skinnyModules option" topic in the users@maven.apache.org mailing list
  

0 votes, 6 watchers

[jira-importer]

Stephane Nicoll commented

probably, yes but I can't really hardcode that "lib" directory in the sar module since anyone can change that directory and it's not part of spec as WEB-INF/lib is for the war.

[jira-importer]

Roland Asmann commented

Could you make it configurable?

[jira-importer]

Roland Asmann commented

Added a new attachment, please disregard the previous attachment!

This change makes the 'libDir' a parameter on the modules, so you can create skinny versions of your modules.

[jira-importer]

Marat Abrarov commented

Roland Asmann, I implemented support of new skinnyModules option for WAR, SAR, HAR and RAR modules in pull request #24. Your review and testing is highly appreciated.

[jira-importer]

Marat Abrarov commented

Please note that solution of this issue provided in pull request #24 should solve MRAR-9 too (when skinnyModules option is turned on).

[jira-importer]

Roland Asmann commented

Marat Abrarov, I's been a while and this was a use-case for a company I have left since... But I will gladly give it a look and see if I maybe can find a case where I can test this. Give me a couple of days though, I am currently in a crunch-period at work.

[jira-importer]

Roland Asmann commented

Marat Abrarov, -I checked your changes and ran it through a test with 1 project I have that has 2 WARs inside an EAR. If I use your new parameter 'skinnyModules', the WARs do not get stripped. Your comments in the code say it should be, so I think there might still be an error in your code somewhere...-

-Unfortunately I was not able to find any project that uses one of the other types...-

OK, scratch that, I'm an idiot... Maybe I should actually build your branch when I do these tests – apparently I forgot to do that...

Edit:

So, testing with your actual branch gave me the expected results.

I was in contact with a friend of mine, from the customer that had this issue. They currently don't have a need for this, but he is checking if he can find the old project that used this. If he can find it, I'll gladly test again, but I think it will work there as well.

[jira-importer]

Marat Abrarov commented

Hi Roland Asmann.

Are there any news about validation you mentioned in that comment? I'd like to complete with pull requests for Maven EAR Plugin and release a new version this year :)

Thank you.

[jira-importer]

Roland Asmann commented

Marat Abrarov: Sorry, I missed the mail that you posted another comment...

My friend managed to find the old project and sent it to me. I think I can get it to build again, working on that right now... Might take me a bit though, I'm not sure if I have access to all dependencies without my friend. But I promise to have an answer either way by the weekend!

[jira-importer]

Roland Asmann commented

Marat Abrarov: Got the old project to build again! And I am pleased to report that your changes work as I expect them too! Like I said before, I am not able to run the project, but the build looks fine!

So please, go ahead and release this!

[jira-importer]

Hervé Boutemy commented

PR merged (with last commit amended) into 954b736

 

thanks a lot Marat