[MEAR-182] Skinny WAR's - Skip Class-Path Modification in Manifest

[jira-importer]

Mario Däpp opened MEAR-182 and commented

From Java EE 5, a library directory may be specified in the application.xml (element library-directory). The Maven EAR Plugin already supports this for generating the application.xml (value of property defaultLibBundleDir).

The Java EE 5 specification mandates that all JAR files contained in the library directory be made available to all modules within the EAR file (cf. chapter EE.8.2.1 Bundled Libraries, section 2).

If one specifies both the skinnyWars (value = true) and defaultLibBundleDir parameters, the libraries will be removed from the WAR and copied to the defaultLibBundleDir. They will also be added to the Class-Path in the WAR files manifest. This is unnecessary as per the Java EE 5 specification. Even worse, it breaks my EAR on WebLogic (classloading issues).

I therefore propose the following improvement to the skinny WAR's functionality: If the Java EE version is 5 or greater and the defaultLibBundleDir has been specified, the Class-Path in the WAR's manifest should remain unchanged.

I've created a corresponding patch and integration test.

---

Affects: 2.9

Attachments:

• MEAR-182-patch.txt (11.60 kB)

Issue Links:

• MEAR-292 skipClassPathModification option should prevent adding Class-Path entry into MANIFEST.mf
  ("causes")

Remote Links:

• GitHub Pull Request #28
  

1 votes, 4 watchers

[jira-importer]

Karl Heinz Marbaise commented

After taking a look into that i would suggest to make an supplemental option like skipClassPathModification which is set to false by default cause otherwise this would change the default behaviour of the plugin which is not a good way. If set to true it could do exactly what you suggested.

[jira-importer]

Mario Däpp commented

Sounds good. This fix will be much appreciated.

[jira-importer]

Mark Howard commented

We're also having issues with this - maven-ear-plugin 2.8 didn't modify the classpath, so this is a regression for us. We also can't get the classpath to work with weblogic (probably relating to using transitive dependencies), so are currently stuck with the slow 2.8 release.

[jira-importer]

Karl Heinz Marbaise commented

Fixed in r1645058.
Patch of Mario Däpp applied with enhancement to use the discussed option.

[jira-importer]

Karl Heinz Marbaise commented

Followup in r1645085. Fixed IT.

[jira-importer]

Marat Abrarov commented

It looks like there is a bug in implementation of skipClassPathModification option introduced in MEAR-182. If skipClassPathModification is true and original MANIFEST.mf of EAR module artifact has no Class-Path entry, then empty Class-Path entry is added into EAR module. I tried to fix this bug in pull request #28. Please review and merge if agree.