[MEAR-216] Handling test JARs as regular JARs#22
Merged
hboutemy merged 13 commits intoapache:masterfrom Dec 20, 2020
Merged
Conversation
mabrarov
changed the title
Contributor
Author
|
@elharo, could you please trigger Jenkins build for this pull request? |
Contributor
Author
Contributor
Author
|
Need to check one more case I found recently. The case (I'll add a test for it) may demonstrate that this pull request is wrong and needs further work. Please, don't merge this pull request until I reply with result of my check. |
Contributor
Author
|
I fixed that issue and this pull request is ready for review now. @elharo and @hboutemy, your help with Jenkins build, review and merging is appreciated. Thank you. |
…with JBoss Packaging Maven Plugin.
# Conflicts: # pom.xml # src/main/java/org/apache/maven/plugins/ear/HarModule.java # src/main/java/org/apache/maven/plugins/ear/RarModule.java # src/main/java/org/apache/maven/plugins/ear/SarModule.java # src/main/java/org/apache/maven/plugins/ear/WebModule.java # src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
Contributor
Author
|
Merged conflicts were resolved. Please trigger a new Jenkins build. |
elharo
reviewed
Dec 6, 2020
Contributor
Author
|
This PR was successfully built by Jenkins. Is it possible to get this PR merged? |
Contributor
Author
Member
|
you're right, merged |
|
Resolve #392 |
1 similar comment
|
Resolve #392 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.