Skip to content

[MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANIFEST.mf#29

Merged
elharo merged 2 commits intoapache:masterfrom
mabrarov:MEAR-292
Dec 22, 2020
Merged

[MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANIFEST.mf#29
elharo merged 2 commits intoapache:masterfrom
mabrarov:MEAR-292

Conversation

@mabrarov
Copy link
Copy Markdown
Contributor

[MEAR-292] - Don't add MANFIEST.mf Class-Path entry for EAR module if skipClassPathModification is true and original MANFIEST.mf of EAR module artifact doesn't contain Class-Path entry.

… skipClassPathModification is true and original MANFIEST.mf of EAR module artifact doesn't contain Class-Path entry.
@mabrarov
Copy link
Copy Markdown
Contributor Author

Note that Jenkins build can fail due to the bug introduced by pull request #26.

@mabrarov
Copy link
Copy Markdown
Contributor Author

@hboutemy

Comment thread src/it/skinny-wars-javaee5/ear-module/pom.xml Outdated
Comment thread src/it/skinny-wars-javaee5/ear-module/pom.xml
Comment thread src/main/java/org/apache/maven/plugins/ear/EarMojo.java Outdated
@elharo elharo changed the title [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANIFEST.mf Dec 20, 2020
@mabrarov
Copy link
Copy Markdown
Contributor Author

@elharo,

It looks like part (windows-jdk15 stage) of the Jenkins build failed due to internal issue of the pipeline:

[withMaven] Options: [org.jenkinsci.plugins.pipeline.maven.publishers.GeneratedArtifactsPublisher[disabled=true], JunitTestsPublisher[disabled=false,healthScaleFactor=,keepLongStdio=false,ignoreAttachments=false], org.jenkinsci.plugins.pipeline.maven.publishers.FindbugsAnalysisPublisher[disabled='true', healthy='', unHealthy='', thresholdLimit='low'], org.jenkinsci.plugins.pipeline.maven.publishers.TasksScannerPublisher[disabled='true', healthy='', unHealthy='', thresholdLimit='low'], org.jenkinsci.plugins.pipeline.maven.publishers.DependenciesFingerprintPublisher[disabled=true, scopes=[compile, provided, runtime], versions={snapshot:true, release:false}], org.jenkinsci.plugins.pipeline.maven.publishers.PipelineGraphPublisher[disabled=true, scopes=[compile, provided, runtime], versions={snapshot:true, release:false}, skipDownstreamTriggers=false, lifecycleThreshold=deploy, ignoreUpstreamTriggers=false]]
[withMaven] Available options: 
[withMaven] using JDK installation jdk_15_latest
[withMaven] using Maven installation 'maven_3.6.2_windows'
[Pipeline] {
[Pipeline] dir
Running in f:\jenkins\jenkins-slave\712657a4\workspace\en-box_maven-ear-plugin_mear-292@2\m
[Pipeline] {
[Pipeline] isUnix
[Pipeline] bat
 > git clean -fdx # timeout=10

f:\jenkins\jenkins-slave\712657a4\workspace\en-box_maven-ear-plugin_mear-292@2\m>mvn -P+run-its -Dmaven.test.failure.ignore=true -Dfindbugs.failOnError=false -Dfindbugs.skip=true clean verify 
----- withMaven Wrapper script -----
The JAVA_HOME environment variable is not defined correctly 
This environment variable is needed to run this program 
NB: JAVA_HOME should point to a JDK not a JRE 
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // withMaven
[Pipeline] echo
[FAILURE-004] hudson.AbortException: script returned exit code 1
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // ws
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] }
Failed in branch windows-jdk15

Could you please trigger a one more build?

Copy link
Copy Markdown
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the windows-15 pipeline is indeed flaky. I'll rerun it.

@elharo
Copy link
Copy Markdown
Contributor

elharo commented Dec 22, 2020

Jenkins is being annoying. Trying again in a new branch:
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/mear-292B/

Copy link
Copy Markdown
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins passed the third time. We really need to do something about the flakiness of our CI infrastructure.

@jira-importer
Copy link
Copy Markdown

Resolve #173

1 similar comment
@jira-importer
Copy link
Copy Markdown

Resolve #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants