[MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANIFEST.mf#29
Merged
elharo merged 2 commits intoapache:masterfrom Dec 22, 2020
Merged
Conversation
… skipClassPathModification is true and original MANFIEST.mf of EAR module artifact doesn't contain Class-Path entry.
Contributor
Author
Contributor
Author
elharo
reviewed
Dec 20, 2020
Contributor
Author
|
It looks like part (windows-jdk15 stage) of the Jenkins build failed due to internal issue of the pipeline: Could you please trigger a one more build? |
elharo
reviewed
Dec 21, 2020
Contributor
elharo
left a comment
There was a problem hiding this comment.
Yes, the windows-15 pipeline is indeed flaky. I'll rerun it.
Contributor
|
Jenkins is being annoying. Trying again in a new branch: |
elharo
approved these changes
Dec 22, 2020
Contributor
elharo
left a comment
There was a problem hiding this comment.
Jenkins passed the third time. We really need to do something about the flakiness of our CI infrastructure.
|
Resolve #173 |
1 similar comment
|
Resolve #173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MEAR-292] - Don't add MANFIEST.mf Class-Path entry for EAR module if skipClassPathModification is true and original MANFIEST.mf of EAR module artifact doesn't contain Class-Path entry.