Skip to content

Replace FileUtils.fileExists(String) with JDK provided API #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slachiewicz merged 1 commit into from
Nov 9, 2025
Merged

Replace FileUtils.fileExists(String) with JDK provided API #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/test/java/org/apache/maven/plugins/ejb/EjbMojoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import org.apache.maven.plugins.ejb.stub.MavenProjectResourcesStub;
import org.apache.maven.plugins.ejb.utils.JarContentChecker;
import org.apache.maven.project.MavenProject;
import org.codehaus.plexus.util.FileUtils;

/**
* EJB plugin Test Case
Expand Down Expand Up @@ -578,11 +577,11 @@ protected void assertJarCreation(
project.getBuild().getDirectory() + "/" + DEFAULT_JAR_NAME + "-" + classifier + "-client.jar";
}

assertEquals("Invalid value for ejb-jar creation", ejbJarCreated, FileUtils.fileExists(checkedJarFile));
assertEquals("Invalid value for ejb-jar creation", ejbJarCreated, new File(checkedJarFile).exists());
assertEquals(
"Invalid value for ejb-jar client creation",
ejbClientJarCreated,
FileUtils.fileExists(checkedClientJarFile));
new File(checkedClientJarFile).exists());
}

protected void assertJarCreation(final MavenProject project, boolean ejbJarCreated, boolean ejbClientJarCreated) {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBasicStub.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public MavenProjectBasicStub(String id) throws Exception {
// set isolated root directory
testRootDir = PlexusTestCase.getBasedir() + "/target/test-classes/unit/test-dir/" + identifier;

if (!FileUtils.fileExists(testRootDir)) {
if (!new File(testRootDir).exists()) {
FileUtils.mkdir(testRootDir);
}

Expand Down
8 changes: 4 additions & 4 deletions src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBuildStub.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,11 @@ public void setupBuildEnvironment() throws Exception {
// populate dummy resources and dummy test resources

// setup src dir
if (!FileUtils.fileExists(resourcesDirectory)) {
if (!new File(resourcesDirectory).exists()) {
FileUtils.mkdir(resourcesDirectory);
}

if (!FileUtils.fileExists(testResourcesDirectory)) {
if (!new File(testResourcesDirectory).exists()) {
FileUtils.mkdir(testResourcesDirectory);
}

Expand All @@ -183,11 +183,11 @@ public void setupBuildEnvironment() throws Exception {
setupRootFiles();

// setup target dir
if (!FileUtils.fileExists(outputDirectory)) {
if (!new File(outputDirectory).exists()) {
FileUtils.mkdir(outputDirectory);
}

if (!FileUtils.fileExists(testOutputDirectory)) {
if (!new File(testOutputDirectory).exists()) {
FileUtils.mkdir(testOutputDirectory);
}

Expand Down
Loading