Skip to content

Add null checks for modelId in PluginWrapper#974

Open
cpfeiffer wants to merge 1 commit intoapache:masterfrom
cpfeiffer:patch-1
Open

Add null checks for modelId in PluginWrapper#974
cpfeiffer wants to merge 1 commit intoapache:masterfrom
cpfeiffer:patch-1

Conversation

@cpfeiffer
Copy link
Copy Markdown

In certain special scenarios (virtual maven-tiles), modelId can be null.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

In certain special scenarios (virtual maven-tiles), modelId can be null.
@cpfeiffer
Copy link
Copy Markdown
Author

cpfeiffer commented Apr 17, 2026

Fixes #971

@slawekjaranowski slawekjaranowski added the bug Something isn't working label Apr 21, 2026
@slawekjaranowski slawekjaranowski self-assigned this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE in requirePluginVersions rule when version location cannot be inferred

2 participants