[MRESOURCES-284] Support JSON format for parameter filter files#31
Closed
ImadBL wants to merge 3 commits intoapache:masterfrom
Closed
[MRESOURCES-284] Support JSON format for parameter filter files#31ImadBL wants to merge 3 commits intoapache:masterfrom
ImadBL wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
not sure we want to introduce such dependency on json... |
Member
I agree with you. This PR is logically incompatible with other setups and will break consistently. |
Member
|
so what alternative? |
Contributor
|
A more suitable format (other than JSON) should be chosen as an alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This concerns the maven-resources-plugin (3.2.1-SNAPSHOT) and maven-filtering (3.3.0-SNAPSHOT) plugins.
with this evolution it is now possible to add configuration files with json format. the second part of this evolution is to have to use a one configuration json file for all environments (dev, preprod, prod...etc )
for more example check: MRESOURCES-284
please note that you must accept the PR first for maven-filtering (3.3.0-SNAPSHOT)
because maven-resources-plugin (3.2.1-SNAPSHOT) need maven-filtering (3.3.0-SNAPSHOT)
if you have any questions do not hesitate, hoping that I have detailed well
Best regards
Imad BELMOUJAHID
@ImadBL