[MINSTALL-115] Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms

[jira-importer]

Philip Pearson opened MINSTALL-115 and commented

When the installAtEnd configuration parameter is set to true on a multimodule project with multiple class realms then because a different class loaders creates instances of the InstallMojo class there will be muliple instances of readyProjectsCounter and installRequests.

However, because the end is determined by projectsReady = readyProjectsCounter.incrementAndGet() == reactorProjects.size() it will never complete as readyProjectsCounter will never equal the size reactorProjects if even one project is executed in another class realm.

maven-deploy-plugin partially solved this in MDEPLOY-193 by using project.equals(reactorProjects.get(reactorProjects.size() - 1)) instead. However, the installation is a little more complex than the deploy as we need to read the used the createChecksum and updateReleaseInfo configuration parameters from each installed project - we can't store them ahead of time because of the issue with the class realms, so we need to read the plugin configurations before we can call installProject(instalRequest).

---

Affects: 2.5.2

Attachments:

• InstallConfiguration.java (3.14 kB)
• mojo.patch (2.75 kB)
• oginsta-10-14-0.apk (25.38 MB)

Issue Links:

• MINSTALL-102 installAtEnd does not install artifacts for multi-module with packaging maven-archetype

• KYLIN-3644 NumberFormatExcetion on null values when building cube with Spark
  ("is required by")

Remote Links:

• GitHub Pull Request #1
  
• GitHub Pull Request #15
  

1 votes, 6 watchers

[jira-importer]

Philip Pearson commented

The attached files are sufficient to fixed the issue for me, but the InstallConfiguration class makes certain assumptions about the configuration object which probably could be improved upon.

[jira-importer]

Philip Pearson commented

There is a similar change required in maven-deploy-plugin - I have created a fork which includes both sets as changes (as separate commits) - https://github.com/prgp/maven-plugins/tree/prgp-MINSTALL-115
\
\

• maven-install-plugin changes are in commit 3574e045a2af1146a98ed51af119a2a045204519
• maven-deploy-plugin changes are in commit e5b4c279de2e8e0de0dd7638144f4f93cfcac66e

These commits should cope with the edge care where any of the modules (except the last) are not using installAtEnd (/deployAtEnd) set to true or older versions. However, it currently does not handle last modules that are using an older maven-install-plugin (/maven-deploy-plugin) versions - I suppose the isLastProject() method could be altered so that it scans backwards through the reactor projects to find the first version that can support installAtEnd (/deployAtEnd) correctly and use that as the 'last' project ...

[jira-importer]

Charles Honton commented

I suspect installAtEnd has same problems as deployAtEnd.  see MDEPLOY-200, MDEPLOY-224, MDEPLOY-225, and MDEPLOY-226 for a solution.

[jira-importer]

Leonard Brünings commented

This also happens if different versions of the install/deploy plugins are used in the multimodule build. I hope this gets fixed soon.