Skip to content

[MINSTALL-115] installAtEnd fails with multiple class realms #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chonton wants to merge 1 commit into from
Closed

[MINSTALL-115] installAtEnd fails with multiple class realms #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/main/java/org/apache/maven/plugins/install/InstallMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,17 @@ public class InstallMojo
private List<MavenProject> reactorProjects;

/**
* Whether every project should be installed during its own install-phase or at the end of the multimodule build. If
* set to {@code true} and the build fails, none of the reactor projects is installed.
* Whether every project should be installed during its own install-phase or at the end of the
* multi-module build. If set to {@code true} and the build fails, none of the reactor projects
* is installed.
*
* In order for this flag to work properly, all modules of the multi-module must set this
* property to the same value and all modules must have the same value for the skip property.
* If this property or the skip property are inconsistently set in different projects, any
* project with this property set to true will not be installed either immediately nor at the
* end of the build. See details in
* <a href="https://issues.apache.org/jira/browse/MINSTALL-115">MINSTALL-115</a>
*
* <strong>(experimental)</strong>
*
* @since 2.5
Expand Down
17 changes: 17 additions & 0 deletions src/site/fml/faq.fml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,22 @@ under the License.
</p>
</answer>
</faq>
<faq id="question">
<question>Why isn't <i>installAtEnd</i> property working?</question>
<answer>
<p>
The <i>installAtEnd</i> property must be set consistently in all modules and the <i>skip</i>
property must be set consistently in all modules. If either property is not consistent, any
module with <i>installAtEnd</i> set to true will not be installed.
</p>
<p>
An alternative to using <i>installAtEnd</i> is to have the build script invoke Maven twice:
<pre>
mvn verify
mvn install:install
</pre>
</p>
</answer>
</faq>
</part>
</faqs>