[MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport by cstamas · Pull Request #158 · apache/maven-integration-testing

cstamas · 2022-05-11T08:31:17Z

An IT for Maven 3.9+ that "exercise" both resolver transport: wagon and native (so we have 2 tests both forcing transport with -Dmaven.resolver.transport one wagon (which is default, but setting is there to be explicit) and once native.

It builds a project that needs a plugin (to pull it will use set transport), and that plugin will use resolver as well to resolve set artifact. If any of these fails, maven project fails.

Current maven 3.9.x build will FAIL due NoSuchMethod error, as expected.

With PR apache/maven#732

Bootstrap.Bootstrap()........................................ OK (3.1 s)
mng7470 ResolverTransport.ResolverTransportNative().......... 3332 [main] INFO org.eclipse.jetty.server.Server - jetty-9.0.4.v20130625
3397 [main] INFO org.eclipse.jetty.server.ServerConnector - Started ServerConnector@6032d904{HTTP/1.1}{0.0.0.0:34895}
OK (1.7 s)
mng7470 ResolverTransport.ResolverTransportWagon()........... OK (1.6 s)

michael-o

Where is the verification that the transport actually works, i.e., the right one is picked?

cstamas · 2022-05-11T08:36:28Z

Where is the verification that the transport actually works, i.e., the right one is picked?

Maven build fails if project deps cannot be resolved... is that what you asking?

michael-o · 2022-05-11T08:40:23Z

Where is the verification that the transport actually works, i.e., the right one is picked?

Maven build fails if project deps cannot be resolved... is that what you asking?

Yes, this is what I will look for. Can you add this as a comment to the tests. It is not obvious from the code itself.

cstamas · 2022-05-11T08:43:46Z

Yes, this is what I will look for. Can you add this as a comment to the tests. It is not obvious from the code itself.

Done.

michael-o · 2022-05-11T08:45:14Z

Testing...

cstamas · 2022-05-11T09:01:20Z

Do not merge pls, I'll do myself once done

michael-o · 2022-05-11T09:09:57Z

[INFO] Downloading from maven-core-it: http://localhost:53770/org/apache/maven/its/resolver-transport/wagon/dependency/1.0/dependency-1.0.pom
[WARNING] Checksum validation failed, expected '97641443fee307b6c3593080be865df89ace3d86' (REMOTE_EXTERNAL) but is actually 'cd16a85341375c7f9dda5edd75dedb83e213e425' from maven-core-it for http://localhost:53770/org/apache/maven/its/resolver-transport/wagon/dependency/1.0/dependency-1.0.pom

michael-o · 2022-05-11T09:18:02Z

On

Java version: 1.8.0_322, vendor: OpenJDK BSD Porting Team, runtime: /usr/local/openjdk8/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "freebsd", version: "12.3-stable", arch: "amd64", family: "unix"

cstamas · 2022-05-11T09:56:42Z

@michael-o @slawekjaranowski so pushed all I wanted, and locally tested, updated description.

michael-o · 2022-05-11T10:10:44Z

Will test again...

slawekjaranowski

In both tests I see in logs ..

[DEBUG] Using transporter WagonTransporter ...

Is it ok?

slawekjaranowski · 2022-05-11T10:27:17Z

We should also check what happens if wrong transport will be provided, like maven.resolver.transport=xxx
We will be sure that property is used at all

cstamas · 2022-05-11T10:27:39Z

Is it ok?

That should not happen, especially as now assertion to debug log is added. Did you return the removed line?

cstamas · 2022-05-11T10:34:52Z

We should also check what happens if wrong transport will be provided, like maven.resolver.transport=xxx We will be sure that property is used at all

IMHO, this is not a UT, this IT merely ensures that selected transport IS used and WORKS.

slawekjaranowski · 2022-05-11T10:50:19Z

Now i have ...

Caused by: java.lang.NoSuchMethodError: org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksums(Lorg/eclipse/aether/artifact/Artifact;ZLjava/net/URI;)Ljava/util/List;
    at org.eclipse.aether.connector.basic.BasicRepositoryConnector.get (BasicRepositoryConnector.java:257)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads (DefaultArtifactResolver.java:520)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve (DefaultArtifactResolver.java:408)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts (DefaultArtifactResolver.java:235)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact (DefaultArtifactResolver.java:212)
    at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact (DefaultRepositorySystem.java:272)
    at org.apache.maven.resolver.examples.maven.ResolveArtifactMojo.execute (ResolveArtifactMojo.java:98)

cstamas · 2022-05-11T10:51:56Z

@slawekjaranowski cool, that's expected with latest maven 3.9.x build, as it uses resolver 1.8.0 but has no fix in apache/maven#732 Now, to verify, build locally that PR and run ITs with it, and they should all pass OK

slawekjaranowski · 2022-05-11T10:53:12Z

Both tests use the same project directory .... pleas add

verifier.setLogFileName( ... );

without it we have logs in file log.txt which content logs from last executed test

cstamas · 2022-05-11T10:59:08Z

Both tests use the same project directory .... pleas add
verifier.setLogFileName( ... );
without it we have logs in file log.txt which content logs from last executed test

fixed

slawekjaranowski

build pass
assertions works

michael-o

I am quite surprised that Jetty output is visible, MNG-5771 has a Jetty-based test as well, but no output is seen. Any idea? I do not see any diff in the source code.

cstamas · 2022-05-11T14:27:54Z

Fix merged, so the IT can be as well....

michael-o · 2022-05-11T18:55:41Z

Still testing...

michael-o · 2022-05-11T20:36:50Z

Works for me now except for the JEtty log output which I don't understand....

cstamas · 2022-05-11T20:58:14Z

apache/maven#732 is merged, so am merging this one as well (ongoing branches not having merged PR will fail here)

[MNG-7470] mvn 3.9+ IT that uses wagon (default) and native transport

57b57cb

cstamas requested review from gnodet and michael-o May 11, 2022 08:31

cstamas self-assigned this May 11, 2022

michael-o requested changes May 11, 2022

View reviewed changes

Comment thread core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java Outdated

Comment thread core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java Outdated

Add spaces

fbfb1dd

cstamas added 2 commits May 11, 2022 10:40

Fix repo POM GAVs

9f9cf45

Explain intent

bc46631

michael-o self-requested a review May 11, 2022 08:45

slawekjaranowski self-requested a review May 11, 2022 08:50

slawekjaranowski reviewed May 11, 2022

View reviewed changes

Comment thread core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java Outdated

Comment thread core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java Outdated

Add in the twist

3a40786

Collaps two test projects into one, they are same

6d2435a

slawekjaranowski requested changes May 11, 2022

View reviewed changes

Assert expected transport is used, that is logged as DEBUG

b07dd49

cstamas mentioned this pull request May 11, 2022

[MNG-7471] 3.9.x Make Resolver util and connector-basic provided apache/maven#732

Closed

Separate logs, collapse test

522f3d8

Simplify POM for demo plugin

ce7d1ef

slawekjaranowski reviewed May 11, 2022

View reviewed changes

Comment thread core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java Outdated

Fix log snippet verification

e9b61eb

cstamas mentioned this pull request May 11, 2022

[MNG-7470] Quarkus build #155

Closed

slawekjaranowski approved these changes May 11, 2022

View reviewed changes

michael-o requested changes May 11, 2022

View reviewed changes

Comment thread core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java Outdated

Comment thread core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java Outdated

Apply PR comments

33b6194

Drop custom method, there is verifier method to use

1974202

cstamas requested a review from michael-o May 11, 2022 17:19

Make text files in repo portable

ea5595a

Align test to other tests with Jetty

210fc37

michael-o approved these changes May 11, 2022

View reviewed changes

cstamas merged commit 8c9cb88 into master May 11, 2022

cstamas deleted the mng-7470-resolver-transport branch May 11, 2022 20:59

Conversation

cstamas commented May 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-o left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cstamas commented May 11, 2022

Uh oh!

michael-o commented May 11, 2022

Uh oh!

cstamas commented May 11, 2022

Uh oh!

michael-o commented May 11, 2022

Uh oh!

cstamas commented May 11, 2022

Uh oh!

michael-o commented May 11, 2022

Uh oh!

michael-o commented May 11, 2022

Uh oh!

Uh oh!

Uh oh!

cstamas commented May 11, 2022

Uh oh!

michael-o commented May 11, 2022

Uh oh!

slawekjaranowski left a comment

Choose a reason for hiding this comment

Uh oh!

slawekjaranowski commented May 11, 2022

Uh oh!

cstamas commented May 11, 2022

Uh oh!

cstamas commented May 11, 2022

Uh oh!

slawekjaranowski commented May 11, 2022

Uh oh!

cstamas commented May 11, 2022

Uh oh!

slawekjaranowski commented May 11, 2022

Uh oh!

cstamas commented May 11, 2022

Uh oh!

Uh oh!

slawekjaranowski left a comment

Choose a reason for hiding this comment

Uh oh!

michael-o left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cstamas commented May 11, 2022

Uh oh!

michael-o commented May 11, 2022

Uh oh!

michael-o commented May 11, 2022

Uh oh!

cstamas commented May 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cstamas commented May 11, 2022 •

edited

Loading