Skip to content

[MNG-7353] Add missing dependencies to bootstrap.txt #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slawekjaranowski merged 1 commit into from
Aug 24, 2022
+12 −9
Merged

[MNG-7353] Add missing dependencies to bootstrap.txt #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7353CliGoalInvocationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ private void run( String id, String goal, String expectedInvocation )
public void testPrefixGoal()
throws Exception
{
run( "pluginPrefix-goal", "dependency:list", "maven-dependency-plugin:2.7:list (default-cli)" );
run( "pluginPrefix-goal", "dependency:list", "maven-dependency-plugin:3.3.0:list (default-cli)" );
}

public void testPrefixGoalAtId()
throws Exception
{
run( "pluginPrefix-goal@id", "dependency:list@id", "maven-dependency-plugin:2.7:list (id)" );
run( "pluginPrefix-goal@id", "dependency:list@id", "maven-dependency-plugin:3.3.0:list (id)" );
}

/**
Expand All @@ -64,7 +64,7 @@ public void testPrefixGoalAtId()
public void testPrefixVersionGoal()
throws Exception
{
run( "pluginPrefix-version-goal", "dependency:2.8:list", "maven-dependency-plugin:2.8:list (default-cli)" );
run( "pluginPrefix-version-goal", "dependency:3.1.1:list", "maven-dependency-plugin:3.1.1:list (default-cli)" );
}

/**
Expand All @@ -73,30 +73,30 @@ public void testPrefixVersionGoal()
public void testPrefixVersionGoalAtId()
throws Exception
{
run( "pluginPrefix-goal@id", "dependency:2.8:list@id", "maven-dependency-plugin:2.8:list (id)" );
run( "pluginPrefix-goal@id", "dependency:3.1.1:list@id", "maven-dependency-plugin:3.1.1:list (id)" );
}

public void testGroupIdArtifactIdGoal()
throws Exception
{
run( "groupId-artifactId-goal", "org.apache.maven.plugins:maven-dependency-plugin:list", "maven-dependency-plugin:2.7:list (default-cli)" );
run( "groupId-artifactId-goal", "org.apache.maven.plugins:maven-dependency-plugin:list", "maven-dependency-plugin:3.3.0:list (default-cli)" );
}

public void testGroupIdArtifactIdGoalAtId()
throws Exception
{
run( "groupId-artifactId-goal@id", "org.apache.maven.plugins:maven-dependency-plugin:list@id", "maven-dependency-plugin:2.7:list (id)" );
run( "groupId-artifactId-goal@id", "org.apache.maven.plugins:maven-dependency-plugin:list@id", "maven-dependency-plugin:3.3.0:list (id)" );
}

public void testGroupIdArtifactIdVersionGoal()
throws Exception
{
run( "groupId-artifactId-version-goal", "org.apache.maven.plugins:maven-dependency-plugin:2.8:list", "maven-dependency-plugin:2.8:list (default-cli)" );
run( "groupId-artifactId-version-goal", "org.apache.maven.plugins:maven-dependency-plugin:3.1.1:list", "maven-dependency-plugin:3.1.1:list (default-cli)" );
}

public void testGroupIdArtifactIdVersionGoalAtId()
throws Exception
{
run( "groupId-artifactId-version-goal@id", "org.apache.maven.plugins:maven-dependency-plugin:2.8:list@id", "maven-dependency-plugin:2.8:list (id)" );
run( "groupId-artifactId-version-goal@id", "org.apache.maven.plugins:maven-dependency-plugin:3.1.1:list@id", "maven-dependency-plugin:3.1.1:list (id)" );
}
}
3 changes: 3 additions & 0 deletions core-it-suite/src/test/resources-filtered/bootstrap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,16 @@ org.apache.maven.plugins:maven-assembly-plugin:2.2-beta-5
org.apache.maven.plugins:maven-assembly-plugin:3.1.0
org.apache.maven.plugins:maven-clean-plugin:${stubPluginVersion}
org.apache.maven.plugins:maven-clean-plugin:2.5
org.apache.maven.plugins:maven-clean-plugin:3.1.0
org.apache.maven.plugins:maven-compiler-plugin:${stubPluginVersion}
org.apache.maven.plugins:maven-compiler-plugin:2.0.2
org.apache.maven.plugins:maven-compiler-plugin:3.1
org.apache.maven.plugins:maven-compiler-plugin:3.8.1
org.apache.maven.plugins:maven-compiler-plugin:3.10.1
org.apache.maven.plugins:maven-dependency-plugin:2.7
org.apache.maven.plugins:maven-dependency-plugin:2.8
org.apache.maven.plugins:maven-dependency-plugin:3.1.1
org.apache.maven.plugins:maven-dependency-plugin:3.3.0
org.apache.maven.plugins:maven-deploy-plugin:${stubPluginVersion}
org.apache.maven.plugins:maven-deploy-plugin:2.7
org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1
Expand Down
2 changes: 1 addition & 1 deletion core-it-suite/src/test/resources/mng-7353-cli-goal-invocation/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ under the License.
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<version>2.7</version><!-- version from core IT bootstrap -->
<version>3.3.0</version>
</plugin>
</plugins>
</pluginManagement>
Expand Down