Remove code corresponding to Maven 2.x and JDK 7#199
Remove code corresponding to Maven 2.x and JDK 7#199slawekjaranowski wants to merge 1 commit intomasterfrom
Conversation
| { | ||
| verifier.getSystemProperties().put( "org.apache.maven.global-settings", path ); | ||
| verifier.addCliOption( '"' + path + '"' ); | ||
| } |
There was a problem hiding this comment.
Do we still need to quote ourselves? Feels weird, no?
There was a problem hiding this comment.
I wouldn't like touch it until Verifier 2.0
There was a problem hiding this comment.
Yes, note that the upgrade to verifier 2.0 will break quotes arguments. Also note that I plan to merge #176 soon and it includes an upgrade to verifier 2.0-SNAPSHOT. Unless we really do want to postpone until it's released, but the snapshots are available on public apache repos, so that's not a dealbreaker, especially as ITs are never released.
There was a problem hiding this comment.
We have many changes in Verifier 2.0.0, many deprecated methods, etc
My proposition is to release Verifier 2.0.0-M1 as is now - I can do it in next weekend.
In next step after #176 we can clean of using deprecated methods we can release next milestone with next part of resolved issues and so on, until to final 2.0.0
As always I like step by step and if it possible split bigger changes.
What do you think?
894c45d to
f3fa66c
Compare
No description provided.