Skip to content

Remove code corresponding to Maven 2.x and JDK 7#199

Closed
slawekjaranowski wants to merge 1 commit intomasterfrom
rm-mvn2
Closed

Remove code corresponding to Maven 2.x and JDK 7#199
slawekjaranowski wants to merge 1 commit intomasterfrom
rm-mvn2

Conversation

@slawekjaranowski
Copy link
Copy Markdown
Member

No description provided.

{
verifier.getSystemProperties().put( "org.apache.maven.global-settings", path );
verifier.addCliOption( '"' + path + '"' );
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to quote ourselves? Feels weird, no?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't like touch it until Verifier 2.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, note that the upgrade to verifier 2.0 will break quotes arguments. Also note that I plan to merge #176 soon and it includes an upgrade to verifier 2.0-SNAPSHOT. Unless we really do want to postpone until it's released, but the snapshots are available on public apache repos, so that's not a dealbreaker, especially as ITs are never released.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have many changes in Verifier 2.0.0, many deprecated methods, etc
My proposition is to release Verifier 2.0.0-M1 as is now - I can do it in next weekend.

In next step after #176 we can clean of using deprecated methods we can release next milestone with next part of resolved issues and so on, until to final 2.0.0

As always I like step by step and if it possible split bigger changes.

What do you think?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a plan to me !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants