Run MNG-7160 test also for Maven 3.8.8+#240
Closed
famod wants to merge 1 commit intoapache:maven-3.8.xfrom
Closed
Conversation
michael-o
requested changes
Feb 14, 2023
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
The entire test needs to be back ported to the maven-3.8.x branch. Master is for 4 and 3.9.x only.
Contributor
Author
|
Ah, my bad - I missed that somehow. I ran it locally like that and it passed. Anyway, I'll create another PR then. |
Member
Not necessary, you can rebase, force push and change the merge base here. |
famod
force-pushed
the
maven-3.8.8-MNG-7160
branch
from
fff1051 to
c6155ed
Compare
Contributor
Author
|
Turns out the test is already there in the 3.8.x branch. |
Member
|
Change applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For apache/maven#999