[MNG-5446] AM/PM inconsistency in mng-3827 and mng-3864 ITs?#3
Closed
mcculls wants to merge 1 commit intoapache:masterfrom
Closed
[MNG-5446] AM/PM inconsistency in mng-3827 and mng-3864 ITs?#3mcculls wants to merge 1 commit intoapache:masterfrom
mcculls wants to merge 1 commit intoapache:masterfrom
Conversation
…s unrelated ITs that happen to expect '2008-11-09 11:59:03.0 PM' to be converted to '2008-11-09 11:59:03' so avoid this by changing the input string in those ITs to use 'AM' instead.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://jira.codehaus.org/browse/MNG-5446 - Maven appears to ignore the PM setting when parsing "2008-11-09 11:59:03.0 PM". This is because the Plexus DateConverter has historically used 'HH'='Hour in day (0-23)' to parse the hours instead of 'hh'='Hour in am/pm (1-12)'. The parsed date-time is therefore written back out as "2008-11-09 11:59:03" instead of "2008-11-09 23:59:03".
If this behaviour is wrong and can be safely fixed then updating the ITs to use "2008-11-09 11:59:03.0 AM" would avoid future IT failures if/when the Date conversion is finally fixed.
If however the old behaviour should be maintained then no change is required in the ITs. (I'd like to know because I'm doing some refactoring of the Sisu-Plexus internals to improve re-use and consistency.)
BTW, does anyone happen to know of plugins whose goals/mojos have Date parameters?