[MNG-4660] Increase usefulness of logging (2)#91
Closed
mthmulders wants to merge 6 commits intoapache:masterfrom
Closed
[MNG-4660] Increase usefulness of logging (2)#91mthmulders wants to merge 6 commits intoapache:masterfrom
mthmulders wants to merge 6 commits intoapache:masterfrom
Conversation
mthmulders
force-pushed
the
more-useful-logging-for-outdated-artifacts-2
branch
from
ea52e0d to
6add0b7
Compare
michael-o
reviewed
Dec 24, 2020
| verifier3.verifyTextInLog( "File 'module-a/target/classes/example.properties' is more recent than the packaged artifact for 'module-a'; using 'module-a/target/classes' instead" ); | ||
| Path path = Paths.get( "module-a", "target", "classes", "example.properties" ); | ||
| verifier3.verifyTextInLog( "File '" + path.toString() + "' is more recent than the packaged artifact for 'module-a'; " | ||
| + "using 'module-a/target/classes' instead" ); |
| { | ||
| verifier3.verifyTextInLog( "File 'module-a/target/classes/example.properties' is more recent than the packaged artifact for 'module-a'; using 'module-a/target/classes' instead" ); | ||
| Path path = Paths.get( "module-a", "target", "classes", "example.properties" ); | ||
| verifier3.verifyTextInLog( "File '" + path.toString() + "' is more recent than the packaged artifact for 'module-a'; " |
Member
There was a problem hiding this comment.
the #toString() is redundant. It will be invoked automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user resumes a build, they could see a message "Packaged artifact is not up-to-date compared to the build output directory". This could even be logged multiple times for one build. It was unclear why it was logged and what a user could do to address it. This test accompanies apache/maven#416.