-
Notifications
You must be signed in to change notification settings - Fork 68
[MPLUGIN-441] Support for the new maven4 api #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b31a929
[MPLUGIN-441] Support mojos using the new maven v4 api
gnodet 58e8011
Cleanup
gnodet 5f97cb4
Do not switch to 4.0.0
gnodet a180328
Do not reorder groupId/artifactId
gnodet b9a91a2
Remove unnecessary plugin definition
gnodet 9875ca2
Remove plexus-utils from the list of banned compile time dependencies
gnodet ab48e26
Document the mojo to indicate that it can't be actually used
gnodet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| invoker.goals.1 = clean install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
|
|
||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>org.apache.maven.its</groupId> | ||
| <artifactId>v4api</artifactId> | ||
| <version>1.0-SNAPSHOT</version> | ||
| <packaging>maven-plugin</packaging> | ||
|
|
||
| <name>Maven Integration Test :: v4api</name> | ||
| <description> | ||
| Test maven-plugin-plugin support for the Maven 4.x api. | ||
| </description> | ||
|
|
||
|
slawekjaranowski marked this conversation as resolved.
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.apache.maven</groupId> | ||
| <artifactId>maven-api-core</artifactId> | ||
| <version>@maven4Version@</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <build> | ||
| <pluginManagement> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.1</version> | ||
| <configuration> | ||
| <source>1.8</source><!-- avoid ${maven.compiler.source} since value is not as expected --> | ||
| <target>1.8</target><!-- avoid ${maven.compiler.target} since value is not as expected --> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </pluginManagement> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-plugin-plugin</artifactId> | ||
| <version>@project.version@</version> | ||
| <executions> | ||
| <execution> | ||
| <id>help-goal</id> | ||
| <goals> | ||
| <goal>helpmojo</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> | ||
94 changes: 94 additions & 0 deletions
94
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| package org.apache.maven.its.v4api; | ||
|
|
||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import org.apache.maven.api.MojoExecution; | ||
| import org.apache.maven.api.ResolutionScope; | ||
| import org.apache.maven.api.Session; | ||
| import org.apache.maven.api.plugin.Log; | ||
| import org.apache.maven.api.plugin.MojoException; | ||
| import org.apache.maven.api.plugin.annotations.Component; | ||
| import org.apache.maven.api.plugin.annotations.Execute; | ||
| import org.apache.maven.api.plugin.annotations.LifecyclePhase; | ||
| import org.apache.maven.api.plugin.annotations.Mojo; | ||
| import org.apache.maven.api.plugin.annotations.Parameter; | ||
| import org.apache.maven.api.Project; | ||
| import org.apache.maven.api.services.ArtifactInstaller; | ||
| import org.apache.maven.api.settings.Settings; | ||
|
|
||
| import java.nio.file.Path; | ||
|
|
||
| /** | ||
| * Test mojo for the v4 api plugin descriptor generation. | ||
| * This mojo is not actually runnable because: | ||
| * - it's using a custom lifecycle which is not defined | ||
| * - it has a @Component dependency on ArtifactInstaller (hint=test) which does not exist | ||
| * | ||
| * @since 1.2 | ||
| */ | ||
| @Mojo( name = "first", requiresDependencyResolution = ResolutionScope.TEST, | ||
| defaultPhase = LifecyclePhase.INTEGRATION_TEST ) | ||
| @Execute( phase = LifecyclePhase.GENERATE_SOURCES, lifecycle = "cobertura" ) | ||
| public class FirstMojo | ||
| implements org.apache.maven.api.plugin.Mojo | ||
| { | ||
|
|
||
| /** | ||
| * Project directory. | ||
| */ | ||
| @Parameter( defaultValue = "${basedir}", readonly = true ) | ||
| private Path basedir; | ||
|
|
||
| @Parameter( property = "first.touchFile", defaultValue = "${project.build.directory}/touch.txt", | ||
| required = true ) | ||
| private Path touchFile; | ||
|
|
||
| /** | ||
| * @since 0.1 | ||
| * @deprecated As of 0.2 | ||
| */ | ||
| @Deprecated | ||
| @Parameter( name = "namedParam", alias = "alias" ) | ||
| private String aliasedParam; | ||
|
|
||
| @Component | ||
| private Session session; | ||
|
|
||
| @Component | ||
| private Project project; | ||
|
|
||
| @Component | ||
| private MojoExecution mojo; | ||
|
|
||
| @Component | ||
| private Settings settings; | ||
|
|
||
| @Component | ||
| private Log log; | ||
|
|
||
| @Component( role = ArtifactInstaller.class, hint = "test" ) | ||
| private Object custom; | ||
|
|
||
| public void execute() | ||
| throws MojoException | ||
| { | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.