[MPLUGIN-419] Allow @Parameter on setters methods

[slawekjaranowski]

• new implementation
• remove some of unused or unneeded methods

[kwin]

Would be good to update https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#parameters and https://maven.apache.org/developers/mojo-api-specification.html subsequently.

[slawekjaranowski]

Would be good to update https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#parameters and https://maven.apache.org/developers/mojo-api-specification.html subsequently.

Agree - documentation should be updated .... we need to review it after release

[slawekjaranowski]

@kwin thanks for approve.
Please look again - I rebased code with your last change.

[kwin]

@kwin thanks for approve. Please look again - I rebased code with your last change.

Still looks good ;-)

[gnodet]

Looks good (apart from the very minor indentation issue).
Some of it had already been integrated in the v4 api through gnodet/maven@6317b8c, but both @Parameter and @Component annotations were actually modified. Does it make sense or should I revert the changes on @Component ?

[slawekjaranowski]

Looks good (apart from the very minor indentation issue). Some of it had already been integrated in the v4 api through gnodet/maven@6317b8c, but both @Parameter and @Component annotations were actually modified. Does it make sense or should I revert the changes on @Component ?

We can add support for @Compoent with method in next step.
I must check if old @Compoent can be injected by method - maybe you know it.

I hope we can also add support for old and new annotation together.
As soon Maven 4 alpha will be published we will have open way for it.

[gnodet]

Looks good (apart from the very minor indentation issue). Some of it had already been integrated in the v4 api through gnodet/maven@6317b8c, but both @Parameter and @Component annotations were actually modified. Does it make sense or should I revert the changes on @Component ?

We can add support for @Compoent with method in next step. I must check if old @Compoent can be injected by method - maybe you know it.

I don't think so at the moment. The question is more whether sisu-inject supports injecting components using setters, but I would think so.

I hope we can also add support for old and new annotation together. As soon Maven 4 alpha will be published we will have open way for it.

That's done in #117 . Both annotation packages are supported. It's ready for review (may need to rebase based on recent changes), but I think it would be better in a new major version of the plugin tools.

[jira-importer]

Resolve #726