Skip to content

[MPLUGIN-419] Fix documentation for maven-plugin-report-plugin#156

Merged
slawekjaranowski merged 1 commit intomasterfrom
MPLUGIN-430
Oct 26, 2022
Merged

[MPLUGIN-419] Fix documentation for maven-plugin-report-plugin#156
slawekjaranowski merged 1 commit intomasterfrom
MPLUGIN-430

Conversation

@slawekjaranowski
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to move the examples links to the parent at https://github.com/apache/maven-plugin-tools/blob/master/src/site/site.xml so it is available in all modules (even in non-Maven plugin ones). WDYT?

@slawekjaranowski
Copy link
Copy Markdown
Member Author

I would suggest to move the examples links to the parent at https://github.com/apache/maven-plugin-tools/blob/master/src/site/site.xml so it is available in all modules (even in non-Maven plugin ones). WDYT?

I can try in such way.

@kwin can you look at build on jenkins ...
Maven site build is broken with error:

javadoc: error - An internal exception has occurred. 
	(java.lang.NullPointerException)
Please file a bug against the javadoc tool via the Java bug reporting page
(http://bugreport.java.com/) after checking the Bug Database (http://bugs.java.com/)
for duplicates. Include error messages and the following diagnostic in your report. Thank you.
java.lang.NullPointerException
	at jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.util.Utils.getFileObject(Utils.java:834)
	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.SourceToHTMLConverter.convertClass(SourceToHTMLConverter.java:176)
	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.SourceToHTMLConverter.generate(SourceToHTMLConverter.java:136)
	at jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.SourceToHTMLConverter.convertRoot(SourceToHTMLConverter.java:117)

Very strange ....
from build: https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/60/

on GitHub the same pass

@kwin
Copy link
Copy Markdown
Member

kwin commented Oct 24, 2022

The NPE in javadoc started with commit 31d088e according to https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/. No idea about it as I cannot reproduce locally.

@slawekjaranowski
Copy link
Copy Markdown
Member Author

NEP in javadocs fixed in #157

@slawekjaranowski slawekjaranowski merged commit 14e3d38 into master Oct 26, 2022
@slawekjaranowski slawekjaranowski deleted the MPLUGIN-430 branch October 26, 2022 07:00
@slawekjaranowski
Copy link
Copy Markdown
Member Author

Connected with issue https://issues.apache.org/jira/browse/MPLUGIN-430

@jira-importer
Copy link
Copy Markdown

Resolve #726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants