Skip to content

Remove unused elements #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slawekjaranowski merged 2 commits into from
Jan 27, 2025
Merged

Remove unused elements #349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1153e1
Remove unused local variable
pzygielo Jan 17, 2025
9a54958
Remove unused parameter
pzygielo Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions maven-plugin-tools-generators/src/main/resources/help-class-source-v4.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ public class HelpMojo
throws MojoException
{
String mojoGoal = getValue( mojo, "goal" );
Node configurationElement = findSingleChild( mojo, "configuration" );
Node description = findSingleChild( mojo, "description" );
if ( goal == null || goal.length() <= 0 || mojoGoal.equals( goal ) )
{
Expand Down Expand Up @@ -283,24 +282,18 @@ public class HelpMojo

for ( Node parameter : parameters )
{
writeParameter( sb, parameter, configurationElement );
writeParameter( sb, parameter );
}
}
}
}

private void writeParameter( StringBuilder sb, Node parameter, Node configurationElement )
private void writeParameter( StringBuilder sb, Node parameter )
throws MojoException
{
String parameterName = getValue( parameter, "name" );
String parameterDescription = getValue( parameter, "description" );

Element fieldConfigurationElement = null;
if ( configurationElement != null )
{
fieldConfigurationElement = (Element) findSingleChild( configurationElement, parameterName );
}

String parameterDefaultValue = getValueOr( parameter, "defaultValue", "" );
if ( isNotEmpty( parameterDefaultValue ) )
{
Expand Down