chore: migrate junit 3/4 tests to junit 5#675
Merged
sparsick merged 14 commits intoapache:masterfrom Dec 20, 2025
Merged
Conversation
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
36 tasks
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
sparsick
force-pushed
the
junit3-migration
branch
from
b03ad1d to
4d61e74
Compare
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Contributor
Author
|
ci on windows fails because of linux path in the test reports. I will prepare a fix for that. |
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
Comment on lines
+282
to
+286
| <dependency> | ||
| <groupId>org.junit.vintage</groupId> | ||
| <artifactId>junit-vintage-engine</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
Contributor
Author
There was a problem hiding this comment.
yes, because if I remove it then I get following error:
[ERROR] org.apache.maven.plugins.pmd.CpdViolationCheckMojoTest.testNotFailOnViolation(CpdViolationCheckMojo) -- Time elapsed: 0.046 s <<< ERROR!
org.junit.jupiter.api.extension.ParameterResolutionException: Unable to resolve parameter
at org.apache.maven.api.plugin.testing.MojoExtension.resolveParameter(MojoExtension.java:176)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: org.codehaus.plexus.component.configurator.ComponentConfigurationException: Cannot create instance of class org.apache.maven.plugins.pmd.stubs.DefaultConfigurationMavenProjectStub
at org.codehaus.plexus.component.configurator.converters.AbstractConfigurationConverter.instantiateObject(AbstractConfigurationConverter.java:184)
at org.codehaus.plexus.component.configurator.converters.composite.ObjectWithFieldsConverter.fromConfiguration(ObjectWithFieldsConverter.java:60)
at org.eclipse.sisu.plexus.CompositeBeanHelper.convertProperty(CompositeBeanHelper.java:265)
at org.eclipse.sisu.plexus.CompositeBeanHelper.setProperty(CompositeBeanHelper.java:202)
at org.codehaus.plexus.component.configurator.converters.composite.ObjectWithFieldsConverter.processConfiguration(ObjectWithFieldsConverter.java:157)
at org.codehaus.plexus.component.configurator.BasicComponentConfigurator.configureComponent(BasicComponentConfigurator.java:37)
at org.codehaus.plexus.component.configurator.AbstractComponentConfigurator.configureComponent(AbstractComponentConfigurator.java:45)
at org.apache.maven.api.plugin.testing.MojoExtension.lookupMojo(MojoExtension.java:411)
at org.apache.maven.api.plugin.testing.MojoExtension.lookupMojo(MojoExtension.java:354)
at org.apache.maven.api.plugin.testing.MojoExtension.resolveParameter(MojoExtension.java:174)
... 2 more
Caused by: java.lang.NoClassDefFoundError: junit/framework/TestCase
at org.apache.maven.plugin.testing.stubs.MavenProjectStub.getBasedir(MavenProjectStub.java:291)
at org.apache.maven.plugins.pmd.stubs.PmdProjectStub.getBasedir(PmdProjectStub.java:84)
at org.apache.maven.plugins.pmd.stubs.DefaultConfigurationMavenProjectStub.getBasedir(DefaultConfigurationMavenProjectStub.java:42)
at org.apache.maven.plugins.pmd.stubs.PmdProjectStub.<init>(PmdProjectStub.java:47)
at org.apache.maven.plugins.pmd.stubs.DefaultConfigurationMavenProjectStub.<init>(DefaultConfigurationMavenProjectStub.java:37)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
at java.base/java.lang.reflect.ReflectAccess.newInstance(ReflectAccess.java:128)
at java.base/java.lang.Class.newInstance(Class.java:725)
at org.codehaus.plexus.component.configurator.converters.AbstractConfigurationConverter.instantiateObject(AbstractConfigurationConverter.java:176)
... 11 more
Caused by: java.lang.ClassNotFoundException: junit.framework.TestCase
... 20 more
I will add a comment to the pom.
Signed-off-by: Sandra Parsick <sandra@parsick.dev>
slawekjaranowski
approved these changes
Dec 16, 2025
|
@sparsick Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.