SSH option preparation#133
Conversation
preparing SSH support
|
I would recommend to collect all SSH private key related issues to one JIRA issue and create ONE PR for it. |
|
I don't have access to your JIRA so feel free. The contribution isn't any rocket science at this stage but shouldn't break anything (backward compatibility shouldn't be affected). If needed then feel free to delete these PRs and create a new one. Before announcing it as new feature it will need to be covered by proper tests. Afterwards it can also be mentioned in the official plugin documentation. |
|
JIRA is available to everyone: https://issues.apache.org/jira/projects/MRELEASE/issues/MRELEASE-1079?filter=allopenissues |
|
any update for this? We encounter a problem that the registered ssh private key is not used by the plugin. |
|
This is already implemented in 7f60b4e. Currently passphrase cannot be parameterized though, look at apache/maven-scm#1222 for a reasoning. |
preparing SSH support
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MJAVADOC-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify -Prun-itsto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.