Skip to content

Import doxia-core packages#144

Merged
kwin merged 2 commits intomasterfrom
bugfix/import-doxia-core-packages
Apr 23, 2026
Merged

Import doxia-core packages#144
kwin merged 2 commits intomasterfrom
bugfix/import-doxia-core-packages

Conversation

@kwin
Copy link
Copy Markdown
Member

@kwin kwin commented Apr 9, 2026

This prevents version conflicts between doxia-sink-api (always provided by m-site-p) and doxia-core (previously loaded in the version requested via the report)

This closes #141

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

This prevents version conflicts between doxia-sink-api (always provided
by m-site-p) and doxia-core (previously loaded in the version requested
via the report)

This closes #141
@kwin kwin requested a review from michael-o April 11, 2026 11:32
*/
private static final List<String> EXCLUDES =
Arrays.asList("doxia-site-renderer", "doxia-sink-api", "maven-reporting-api");
Arrays.asList("doxia-sink-api", "doxia-core", "doxia-site-renderer", "maven-reporting-api");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as maven-reporting-impl can depends on api ... maybe should also be provided?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a concrete example which lead to issues that can be used as IT?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not now

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the impact of EXCLUDES at all since imports are always considered first IIRC or am I wrong here?

Copy link
Copy Markdown
Member Author

@kwin kwin Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"reporting-impl" is not provided by the parent classloader (i.e. the one from m-s-p) therefore cannot be excluded.

@kwin kwin marked this pull request as ready for review April 23, 2026 13:46
@kwin kwin requested a review from slawekjaranowski April 23, 2026 13:51
@kwin kwin merged commit dca86c3 into master Apr 23, 2026
15 checks passed
@kwin kwin deleted the bugfix/import-doxia-core-packages branch April 23, 2026 20:19
@github-actions
Copy link
Copy Markdown

@kwin Please assign appropriate label to PR according to the type of change.

@github-actions github-actions Bot added this to the 2.0.1 milestone Apr 23, 2026
@kwin kwin added the bug Something isn't working label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework class loading for reports with regards to org.apache.maven.doxia.sink.impl.SinkEventAttributeSet

3 participants