[MRESOLVER-98] resolver ant task doesn't appear to obey dependencyManagement

[jira-importer]

Jay Kahrman opened MRESOLVER-98 and commented

We have a dependency in our pom which has dependencies that don't specify an upper bound to the version range. To avoid getting different versions in every build we use a dependencyManagement section in the POM to lock down the version. This works via the maven 3 CLI, and via the old ant-tasks utility we were using (). The maven-resolver-ant-tasks jar doesn't appear to obey the dependencyManagement section, however. 

 

I'm not sure is this is related to MRESOLVER-33 and/or MRESOLVER-10 and if updating maven-resolver-ant-tasks to depend on Maven Resolver 1.4.0 would solve the problem.

 

---

Affects: ant-tasks-1.2.0

Issue Links:

• MRESOLVER-288 Improve Ant task support for dependency management
  ("is duplicated by")
• MRESOLVER-192 Remove support for reading POMs
  ("is superceded by")

Remote Links:

• GitHub Pull Request #2
  

0 votes, 6 watchers

[jira-importer]

Michael Osipov commented

Jay Kahrman, why don't you try to update yourself and retry your resolution? Provide an example wich depicts this issue.

[jira-importer]

Kapil Somani commented

Hi Michael Osipov, I tried rebuilding resolver task with resolverVersion updated to 1.4.0 (from 1.3.3)

I'm getting below test failure

testResolveArtifact:

 

1580241309555 Using remote repository central (https://repo1.maven.org/maven2/, default, releases)

1580241309555 Collecting dependencies

15125 [*ERROR*] *Tests* *run: 6*, Failures: 0, *Errors: 3*, Skipped: 0, Time elapsed: 1.457 s *<<< FAILURE!* - in org.apache.maven.resolver.internal.ant.*ReactorTest*

15125 [*ERROR*] testResolveVersionRange(org.apache.maven.resolver.internal.ant.ReactorTest)  Time elapsed: 1.37 s  <<< ERROR!

org.apache.tools.ant.BuildException: java.lang.ClassCastException: java.lang.NoClassDefFoundError cannot be cast to java.lang.Exception

at org.apache.maven.resolver.internal.ant.ReactorTest.testResolveVersionRange(ReactorTest.java:95)

Caused by: java.lang.ClassCastException: java.lang.NoClassDefFoundError cannot be cast to java.lang.Exception

at org.apache.maven.resolver.internal.ant.ReactorTest.testResolveVersionRange(ReactorTest.java:95)

 

 

 

 

I then skipped tests to create artifact maven-resolver-ant-tasks-1.2.1-SNAPSHOT.jar to include it in my build.xml

BUILD FAILED

/sandbox/ksomani/workspaces/scheduler/build.xml:135: java.lang.NoClassDefFoundError: org/apache/maven/resolver/internal/ant/org/eclipse/aether/internal/impl/CacheUtils

 

Total time: 0 seconds

 

Where build.xml:135 reads:

{{131 <taskdef uri="antlib:org.apache.maven.resolver.ant"
        resource="org/apache/maven/resolver/ant/antlib.xml"
        classpathref="maven.resolver.ant.jar" />}}

135 <resolver:pom file="pom.xml" id="scheduler.pom"/>

136   <resolver:localrepo dir="${maven-localrepo}"/>

 

 

 

 

 

Answering the question you posed for [Jay Kahrman](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jkahrman), here is the pom.xml we are using

 

<?xml version="1.0" encoding="UTF-8"?>

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

..[SNIP]..

<properties>

        <guava.version>27.1-jre</guava.version>

        <ec.version>9.2.0</ec.version>

</properties>

*..[SNIP]..*

</dependencies>

<dependencyManagement>

        <dependencies>

            <!--

                lock down mapdb's unbounded dependencies

                these can be removed once mapdb is upgraded to a version that

                specifies an upper bound on the versions it depends upon

             -->

            <dependency>

                <groupId>com.google.guava</groupId>

                <artifactId>guava</artifactId>

                <version>${guava.version}</version>

            </dependency>

            <dependency>

                <groupId>org.eclipse.collections</groupId>

                <artifactId>eclipse-collections-api</artifactId>

                <version>${ec.version}</version>

            </dependency>

            <dependency>

                <groupId>org.eclipse.collections</groupId>

                <artifactId>eclipse-collections</artifactId>

                <version>${ec.version}</version>

            </dependency>

            <dependency>

                <groupId>org.eclipse.collections</groupId>

                <artifactId>eclipse-collections-forkjoin</artifactId>

                <version>${ec.version}</version>

            </dependency>

            <!-- end mapdb dependency lock down -->

        </dependencies>

    </dependencyManagement>

</project>

 

 

 

 

Please let me know if you need more details

 

Thanks 

[jira-importer]

Michael Osipov commented

Master does not build right now. Please use branch fixed-stuff and report.

[jira-importer]

Kapil Somani commented

Hi Michael,

I have carried out below experiment with both fixed-stuff and 1.2.0-source-release but the maven resolver doesn't seem to honor dependencyManagement section of pom.xml

1. Updated resolverVersion property in pom.xml to 1.4.0
2. Updated mavenVersion property in pom.xml to 3.6.3 (since resolver-provider 3.5.0 had references to deprecated CacheUtils in resolver-imp-1.3.3.jar)

[jira-importer]

William Leung commented

Still not works after updated resolver to 1.4.1 & resolver-provider to 3.6.3

// pom.xml
<project>
    ... ...

    <properties>
        <resolverVersion>1.4.1</resolverVersion>
        <mavenVersion>3.6.3</mavenVersion>
    </properties>

    <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>org.apache.maven.resolver</groupId>
                <artifactId>maven-resolver-api</artifactId>
                <version>${resolverVersion}</version>
            </dependency>
            ... ...
            <dependency>
                <groupId>org.apache.maven</groupId>
                <artifactId>maven-resolver-provider</artifactId>
                <version>${mavenVersion}</version>
            </dependency>
        </dependencies>
    </dependencyManagement>
    <dependencies>
        <dependency>
            <groupId>org.apache.maven.resolver</groupId>
            <artifactId>maven-resolver-ant-tasks</artifactId>
            <version>1.2.0</version>
        </dependency>
    </dependencies>
</project>

mvn dependency:tree

[INFO] my.ci:my-ci-maven-resolver:pom:`snapshot-version`
[INFO] \- org.apache.maven.resolver:maven-resolver-ant-tasks:jar:1.2.0:compile
[INFO]    +- org.apache.maven.resolver:maven-resolver-api:jar:1.4.1:compile
[INFO]    +- org.apache.maven.resolver:maven-resolver-util:jar:1.4.1:compile
[INFO]    +- org.apache.maven.resolver:maven-resolver-impl:jar:1.4.1:compile
[INFO]    |  +- org.apache.maven.resolver:maven-resolver-spi:jar:1.4.1:compile
[INFO]    |  \- org.slf4j:slf4j-api:jar:1.7.25:compile
[INFO]    +- org.apache.maven.resolver:maven-resolver-connector-basic:jar:1.4.1:compile
[INFO]    +- org.apache.maven.resolver:maven-resolver-transport-classpath:jar:1.4.1:compile
[INFO]    +- org.apache.maven.resolver:maven-resolver-transport-file:jar:1.4.1:compile
[INFO]    +- org.apache.maven.resolver:maven-resolver-transport-http:jar:1.4.1:compile
[INFO]    |  +- org.apache.httpcomponents:httpclient:jar:4.5.6:compile
[INFO]    |  |  \- commons-codec:commons-codec:jar:1.10:compile
[INFO]    |  +- org.apache.httpcomponents:httpcore:jar:4.4.10:compile
[INFO]    |  \- org.slf4j:jcl-over-slf4j:jar:1.7.25:runtime
[INFO]    +- org.slf4j:slf4j-nop:jar:1.7.25:runtime
[INFO]    +- org.apache.maven:maven-resolver-provider:jar:3.6.3:compile
[INFO]    |  +- org.apache.maven:maven-model:jar:3.6.3:compile
[INFO]    |  +- org.apache.maven:maven-model-builder:jar:3.6.3:compile
[INFO]    |  |  +- org.apache.maven:maven-artifact:jar:3.6.3:compile
[INFO]    |  |  \- org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.3.4:compile
[INFO]    |  +- org.apache.maven:maven-repository-metadata:jar:3.6.3:compile
[INFO]    |  +- org.codehaus.plexus:plexus-utils:jar:3.2.1:compile
[INFO]    |  \- javax.inject:javax.inject:jar:1:compile
[INFO]    +- org.apache.maven:maven-settings-builder:jar:3.5.0:compile
[INFO]    |  +- org.apache.maven:maven-builder-support:jar:3.5.0:compile
[INFO]    |  +- org.apache.maven:maven-settings:jar:3.5.0:compile
[INFO]    |  +- org.sonatype.plexus:plexus-sec-dispatcher:jar:1.4:compile
[INFO]    |  |  \- org.sonatype.plexus:plexus-cipher:jar:1.4:compile
[INFO]    |  \- org.apache.commons:commons-lang3:jar:3.5:compile
[INFO]    +- org.codehaus.plexus:plexus-interpolation:jar:1.25:compile
[INFO]    \- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.3:compile
[INFO]       \- org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile

// build.xml
<project>
    ...
    <target name="test">
        <resolver:resolve>
            <dependencies>
                <pom file="../maven/resolver/pom.xml"/>
            </dependencies>
            <path refid="cp" />
            <properties  />
        </resolver:resolve>
        <echo message="prop: ${org.apache.maven.resolver:maven-resolver-api:jar}"/>
        <echo message="cp: ${toString:cp}" />
    </target>
</project>

ant test

test:
[resolver:resolve] Resolving artifacts
     [echo] prop: .../.m2/repository/org/apache/maven/resolver/maven-resolver-api/1.3.3/maven-resolver-api-1.3.3.jar
     [echo] cp: .../.m2/repository/org/apache/maven/resolver/maven-resolver-api/1.3.3/maven-resolver-api-1.3.3.jar:...

the resolved properties and paths are all incorrect pointed to artifacts that not overridden by dependencyManagement

[jira-importer]

William Leung commented

Please check apache/maven-resolver-ant-tasks#2

[jira-importer]

William Leung commented

After applying the patch, the resolving mechanism still does not work as expected

test case

  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>org.apache.maven.resolver</groupId>
        <artifactId>maven-resolver-api</artifactId>
        <version>1.4.1</version>
      </dependency>
    </dependencies>
  </dependencyManagement>

  <dependencies>
    <dependency>
      <groupId>org.apache.maven.resolver</groupId>
      <artifactId>maven-resolver-util</artifactId>
      <version>1.4.1</version>
      <scope>test</scope>
    </dependency>
  </dependencies>

the dependency tree

[INFO] \- org.apache.maven.resolver:maven-resolver-util:jar:1.4.1:test
[INFO]    \- org.apache.maven.resolver:maven-resolver-api:jar:1.4.1:test

but the resolver will incorrectly resolve maven-resolver-api as compile scope

[jira-importer]

Michael Osipov commented

Can someone provide a simple reproducer project as tarball?

[jira-importer]

William Leung commented

Michael Osipov

Please check apache/maven-resolver-ant-tasks#2

and the two added test cases from https://github.com/apache/maven-resolver-ant-tasks/pull/2/files#diff-0e9495413c05df4b700eff32a368c03643597dc72fd372c559d9e850f162f321

• testResolvePomWithManagedDeps (resolved)
• testResolvePomWithScopedAndManagement (not yet)

[jira-importer]

Michael Osipov commented

Please note my comment here: apache/maven-resolver-ant-tasks#2 (comment)

[jira-importer]

Michael Osipov commented

Still waiting...

[jira-importer]

William Leung commented

Michael Osipov

for the inconsistent of maven and which this project implements, we had give-up using it

for replacement, we wrote a script to parse the mvn dependency:resolve output to resolve the dependencies

ref https://gist.github.com/lwr/6829cefaab2261cec1cc733f6398b9ac

[jira-importer]

Michael Osipov commented

Alright, you are encouraged to use Maven directly. The feaure is likely to be remove with Ant Tasks 2.0.0.