Skip to content

Refine performance (2nd) #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XenoAmess wants to merge 6 commits into from
Closed

Refine performance (2nd) #1492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02691c4
BfDependencyCollector can share executorService between resolvers
XenoAmess Jun 14, 2025
d0a0269
intern some strings to make use of the new hash cache in String class…
XenoAmess Jun 14, 2025
f295e15
bugfix for MMap with List value usage.(also performance related)
XenoAmess Jun 14, 2025
89b0062
Revert "BfDependencyCollector can share executorService between resol…
XenoAmess Jun 18, 2025
6accca2
Revert "intern some strings to make use of the new hash cache in Stri…
XenoAmess Jun 18, 2025
82f1b17
revert most of the mmap changes to focus on the most severe problem
XenoAmess Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...r-util/src/main/java/org/eclipse/aether/util/graph/manager/AbstractDependencyManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ public DependencyManager deriveChildManager(DependencyCollectionContext context)
Collection<Exclusion> exclusions = managedDependency.getExclusions();
if (!exclusions.isEmpty()) {
if (managedExclusions == this.managedExclusions) {
managedExclusions = MMap.copy(this.managedExclusions);
managedExclusions = MMap.copyWithListValue(this.managedExclusions);
}
Collection<Holder<Collection<Exclusion>>> managed = managedExclusions.get(key);
if (managed == null) {
Expand Down
12 changes: 12 additions & 0 deletions maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/manager/MMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
*/
package org.eclipse.aether.util.graph.manager;

import java.util.ArrayList;
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;

/**
* Warning: this is a special map-like construct that suits only and should be used only in this package!
Expand Down Expand Up @@ -47,6 +50,15 @@ public static <K, V> MMap<K, V> copy(MMap<K, V> orig) {
return new MMap<>(new HashMap<>(orig.delegate));
}

public static <K, V> MMap<K, Collection<V>> copyWithListValue(MMap<K, Collection<V>> orig) {
HashMap<K, Collection<V>> delegateLocal = orig.delegate;
HashMap<K, Collection<V>> newMap = new HashMap<>((int) Math.ceil(delegateLocal.size() / 0.75D));
for (Map.Entry<K, Collection<V>> entry : delegateLocal.entrySet()) {
newMap.put(entry.getKey(), entry.getValue() == null ? null : new ArrayList<>(entry.getValue()));
}
return new MMap<>(newMap);
}

protected final HashMap<K, V> delegate;

private MMap(HashMap<K, V> delegate) {
Expand Down