[MRESOLVER-248] Make DF and BF collector implementations coexist#161
[MRESOLVER-248] Make DF and BF collector implementations coexist#161
Conversation
|
@caiwei-ebay ping |
It is really internal thing of BF skipper, no need for iface + 2 separate classes. Expose and adjust tests.
|
I think I collapsed/deduped mostly what was obvious... |
|
General remark: the convention to name package as "internal" or "impl" should automatically imply this is INTERNAL thing (AFAIK, some OSGi tooling and Takari life-cycle even enforce this). In this case we deal with "internal.impl" 😄 so IMHO it should be really really clear to developer that this is internal implementation... Am just saying this is something generally used, but agree, will update javadoc |
|
@michael-o any blocker here? |
|
@caiwei-ebay all looking good here? Any proposal to change/add? |
|
Will review today/tomorrow. |
Looks good to me. Thanks. |
|
Can you outline how to toggle at https://github.com/apache/maven-resolver/blob/master/src/site/markdown/configuration.md? |
|
Right, doco changes are missing (2 new config keys), will add them |
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
Almost done. Will run tests.
| if ( logger.isDebugEnabled() ) | ||
| { | ||
| stats.put( "BfDependencyCollector.collectTime", time2 - time1 ); | ||
| stats.put( "BfDependencyCollector.transformTime", time3 - time2 ); |
There was a problem hiding this comment.
Stupid question: If you already have the logger class name in the ouput, if necessary, why print it again here?
There was a problem hiding this comment.
am unsure does Maven uses "standard" layout w/ classes as log names... is it? I'd just don't bother 😄
There was a problem hiding this comment.
Yes, you can easily enable with SLF4J Simple, if necessary
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
Looks good now. Please squash and change title: "Make DF and BF collector implementations coexist"
cstamas
changed the title
cstamas
changed the title
|
Resolve #1402 |
5 participants
Revive replaced DF collector, and make them coexists. Default one is "old" DF, while new BF may be activated on demand (based on session config).
This is simple "reshuffle" PR:
So, mostly is simple, just "move around". I'd suggest we merge this as is (if OK), and have another iteration as I think there may be some duplications and maybe other refactoring possibilities.
https://issues.apache.org/jira/browse/MRESOLVER-248